Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: icon misalignment in chromium browsers #203

Merged
merged 4 commits into from
Jun 28, 2024
Merged

fix: icon misalignment in chromium browsers #203

merged 4 commits into from
Jun 28, 2024

Conversation

lewisbirks
Copy link
Collaborator

@lewisbirks lewisbirks commented Jun 27, 2024 •
edited
Loading

📖 Changes

Fix icon alignment for chromium browsers without relying on browser specific overrides

  • Move sizing to the svg rather than the container
  • Change container to use an inline-flex
  • Use a box shadow instead of a border for the hover highlighting

🧪 Testing

Before

Chrome

image

Safari

image

Firefox

image

After

Chrome

image

Safari

image

Firefox

image

@lewisbirks lewisbirks merged commit 9c7af6a into main Jun 28, 2024
3 checks passed
@lewisbirks lewisbirks deleted the fix/icon_positioning branch June 28, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RookiePJ RookiePJ RookiePJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lewisbirks @RookiePJ