feat: allow for custom input parsing #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisbirks
commented
Aug 24, 2022
| @@ -495,7 +495,7 @@ describe('Date picker', () => { | |||
| expect(nextMonthButton.tabIndex).toEqual(0); | |||
| }); | |||
|
|
|||
| it('should allow for selection of a day next month', () => { | |||
| it('should allow for selection of a day last month', () => { | |||
There was a problem hiding this comment.
noticed that intellij was reporting only 79 tests ran instead of 80, this was the reason why
lewisbirks
force-pushed
the
feat/custom-input-parsing
branch
from
73c23e1 to
9e982cc
Compare
Jamesnelson117
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use case
A use case for this option would be to determine the prefix of years that are 2 or less digits, by default JS interprets this as 19XX. This may not be the wanted implementation so this new callback option allows the developer to alter the inputs before they are then validated and used to construct a date.