feat: add tool-versions to scripts and contracts #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @coxmars and @danielcdz here is my pull request, thank you if you let me know what you think. I remain attentive to any changes I have to make. Excellent day bosses. 🫡👨🏻💻 |
danielcdz
requested changes
Jan 23, 2025
cairo/scripts/.tool-versions
Outdated
starknet/contracts/.tool-versions
Outdated
starknet/modules/.tool-versions
Outdated
|
@salazarsebas did you make sure to add the correct versions in the files? |
coxmars
reviewed
Jan 23, 2025
|
I made the changes, please let me know what you think. Thanks for the feedback. |
|
@salazarsebas Once you finished applying the requested changes please click the round button here: |
Done, an apology for not doing it sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Title
Add the .tool-versions file to all relevant scripts and contracts directories that were not there before.
🛠️ Issue
📖 Description
This pul request ensures that the
.tool-versionsfile is added to all directories containing scripts and contract files where it was previously missing. This ensures consistency across the development environment by specifying the exact versions of the tools required for the project in all relevant locations. This addition helps avoid compatibility issues and ensures that developers working on the project use the same tool versions across these directories.📝 Additional Notes