Skip to content

Commit

Permalink
Next Version Bump (#1886)
Browse files Browse the repository at this point in the history
* fix(dropdown): add check for el (#1885)

* chore: update browserslist dependency

* chore: remove empty package.json dependencies block

* chore: update node engines to support v20 (#1888)

Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>

---------

Co-authored-by: Monica Wheeler <monica.wheeler@kajabi.com>
Co-authored-by: Julian Skinner <ju-Skinner@users.noreply.github.com>
Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
  • Loading branch information
4 people authored May 17, 2024
1 parent 8ac5a1d commit 6fcaab1
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 13 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/lint-test-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
env:
NODE_VERSION: ${{ matrix.node-version }}
run: |
if [[ $NODE_VERSION == '18' ]]; then
if (( $NODE_VERSION >= 18 )); then
NODE_OPTIONS=--openssl-legacy-provider npm install -g yarn
else
npm install -g yarn
Expand All @@ -34,7 +34,7 @@ jobs:
env:
NODE_VERSION: ${{ matrix.node-version }}
run: |
if [[ $NODE_VERSION == '18' ]]; then
if (( $NODE_VERSION >= 18 )); then
NODE_OPTIONS=--openssl-legacy-provider yarn install
else
yarn install
Expand All @@ -45,7 +45,7 @@ jobs:
env:
NODE_VERSION: ${{ matrix.node-version }}
run: |
if [[ $NODE_VERSION == '18' ]]; then
if (( $NODE_VERSION >= 18 )); then
NODE_OPTIONS=--openssl-legacy-provider yarn lint
else
yarn lint
Expand All @@ -55,7 +55,7 @@ jobs:
env:
NODE_VERSION: ${{ matrix.node-version }}
run: |
if [[ $NODE_VERSION == '18' ]]; then
if (( $NODE_VERSION >= 18 )); then
NODE_OPTIONS=--openssl-legacy-provider yarn test
else
yarn test
Expand All @@ -65,7 +65,7 @@ jobs:
env:
NODE_VERSION: ${{ matrix.node-version }}
run: |
if [[ $NODE_VERSION == '18' ]]; then
if (( $NODE_VERSION >= 18 )); then
NODE_OPTIONS=--openssl-legacy-provider yarn build
else
yarn build
Expand Down
2 changes: 1 addition & 1 deletion docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"test": "test"
},
"engines": {
"node": "16.x || 18.x",
"node": "16.x || 18.x || 20.x",
"npm": "8.x",
"yarn": "1.x"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/sage-assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"sassdoc/*"
],
"engines": {
"node": "16.x || 18.x",
"node": "16.x || 18.x || 20.x",
"npm": "8.x",
"yarn": "1.x"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/sage-packs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"packs"
],
"engines": {
"node": "16.x || 18.x",
"node": "16.x || 18.x || 20.x",
"npm": "8.x",
"yarn": "1.x"
},
Expand Down
4 changes: 4 additions & 0 deletions packages/sage-react/lib/Dropdown/Dropdown.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ export const Dropdown = ({
let directionX = null;
let directionY = null;
const el = wrapperRef.current;

// if el is null, return
if (!el) return;

// Elements
const button = el;
const panel = el.lastElementChild;
Expand Down
2 changes: 1 addition & 1 deletion packages/sage-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"url": "https://github.com/Kajabi/sage-lib/issues"
},
"engines": {
"node": "16.x || 18.x",
"node": "16.x || 18.x || 20.x",
"npm": "8.x",
"yarn": "1.x"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/sage-system/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"dist/*"
],
"engines": {
"node": "16.x || 18.x",
"node": "16.x || 18.x || 20.x",
"npm": "8.x",
"yarn": "1.x"
},
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6198,9 +6198,9 @@ caniuse-api@^3.0.0:
lodash.uniq "^4.5.0"

caniuse-lite@^1.0.0, caniuse-lite@^1.0.30000981, caniuse-lite@^1.0.30001109, caniuse-lite@^1.0.30001370:
version "1.0.30001521"
resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001521.tgz"
integrity sha512-fnx1grfpEOvDGH+V17eccmNjucGUnCbP6KL+l5KqBIerp26WK/+RQ7CIDE37KGJjaPyqWXXlFUyKiWmvdNNKmQ==
version "1.0.30001618"
resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001618.tgz"
integrity sha512-p407+D1tIkDvsEAPS22lJxLQQaG8OTBEqo0KhzfABGk0TU4juBNDSfH0hyAp/HRyx+M8L17z/ltyhxh27FTfQg==

capital-case@^1.0.4:
version "1.0.4"
Expand Down

0 comments on commit 6fcaab1

Please sign in to comment.