[DSS-328] Upload Card - Layout Update #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anechol
force-pushed
the
feature/upload-card-update
branch
from
14e1ed8 to
97fa66c
Compare
anechol
added
documentation
ju-Skinner
reviewed
Aug 16, 2023
docs/lib/sage_rails/app/views/sage_components/_sage_upload_card.html.erb
Outdated
Show resolved
Hide resolved
ju-Skinner
reviewed
Aug 16, 2023
docs/lib/sage_rails/app/views/sage_components/_sage_upload_card.html.erb
Outdated
Show resolved
Hide resolved
ju-Skinner
reviewed
Aug 16, 2023
ju-Skinner
approved these changes
Aug 16, 2023
pixelflips
approved these changes
Aug 16, 2023
|
|
||
| <h4>Actions area</h4> | ||
| <p>Use the <code>sage_upload_card_actions</code> slot to replace the default button and display custom components, such as dropdowns.</p> | ||
| <p><strong>NOTE:</strong> a file input field and label are <em>included by default in the base component</em>, as seen in the examples above. When applying a custom file input with `sage_upload_card_actions`, set <code>custom_file_input_field</code> to <code>true</code> to remove these defaults.</p> |
There was a problem hiding this comment.
Should the sage_upload_card_actions be wrapped in <code> to match the others?
| ], | ||
| file_selected: true, | ||
| accepted_file_types: ["image/jpg"], | ||
| selection_preview: "https://placekitten.com/360", |
| <h3 class="t-sage-heading-6">Selected Error State</h3> | ||
| <h3>Custom content areas</h3> | ||
| <h4>Instructions area</h4> | ||
| <p>The <code>sage_upload_card_instructions</code> slot provides an area for extended instructions and custom markup.</p> |
There was a problem hiding this comment.
Nitpick: extra space between 'for extended'
ju-Skinner
force-pushed
the
develop
branch
2 times, most recently
from
c85f983 to
39d0349
Compare
ju-Skinner
force-pushed
the
develop
branch
11 times, most recently
from
b5f45fa to
d0f2ff2
Compare
anechol
force-pushed
the
feature/upload-card-update
branch
2 times, most recently
from
b5d7e28 to
fa3b177
Compare
anechol
force-pushed
the
feature/upload-card-update
branch
from
fa3b177 to
3ded589
Compare
anechol
force-pushed
the
feature/upload-card-update
branch
from
3ded589 to
31f5f3d
Compare
anechol
force-pushed
the
feature/upload-card-update
branch
from
31f5f3d to
fc18490
Compare
…in multiple upload cards
anechol
force-pushed
the
feature/upload-card-update
branch
from
fc18490 to
ad36f96
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the Upload Card layout to match with new Figma specs. Descriptions have been added to the React stories for more context. New props have been added to the React component to accommodate the refactor and match the Rails version.
Note: Because of one usage within
kp, theinputPropsprop will remain in React. There is a PR inkpthat will handle updating those versions.Screenshots
Stacked Layout
Testing in
sage-libRails
React
Testing in
kajabi-products(BREAKING) Refactors the Upload Card layout to match with new Figma specs. Will affect existing instances of the Upload Card component in
kpthat utilize Sage classes for styling.Related
DSS-328