Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Icon documentation update (Rails) #1809

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Conversation

pixelflips
Copy link
Member

Description

Updates icon documentation to provide clarity and reduce overall code complexity of examples.

Screenshots

Before After
icon-before icon-after

Testing in sage-lib

  • Navigate to icon
  • Verify documentation updates.

Testing in kajabi-products

  1. (LOW) Update to icon rails component documentation. No effect on KP expected

Related

N/A

@pixelflips pixelflips self-assigned this Oct 11, 2023
@pixelflips pixelflips marked this pull request as ready for review October 11, 2023 21:50
@pixelflips pixelflips requested a review from a team October 11, 2023 21:50
Copy link
Collaborator

@monicawheeler monicawheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great improvements! I added a couple of suggestions looking for your thoughts!

@pixelflips pixelflips requested review from monicawheeler and a team October 16, 2023 16:56
@ju-Skinner ju-Skinner requested a review from a team October 16, 2023 17:00
Copy link
Collaborator

@monicawheeler monicawheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@pixelflips pixelflips merged commit 99fe5f6 into develop Oct 16, 2023
4 checks passed
@pixelflips pixelflips deleted the docs/pl-onsite-docs-icon branch October 16, 2023 17:06
@pixelflips pixelflips mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants