docs(modal): Rails Modal Documentation #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflips
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Left one minor comment on adding dividers to match other docs updates.
The only other feedback is we may need a better description copy for the top of the page, but not a showstopper right now. Could be updated in a follow-up if needed.
Otherwise, this is a great update! Really nice work!
pixelflips
reviewed
Oct 17, 2023
| @@ -567,7 +567,7 @@ def sage_components | |||
| }, | |||
| { | |||
| title: "modal", | |||
| description: "Sage modal", | |||
| description: "Modals are overlays used to display content on a layer above the page, preventing users from interacting with content behind the modal.", | |||
ju-Skinner
approved these changes
Oct 19, 2023
monicawheeler
approved these changes
Oct 24, 2023
anechol
approved these changes
Oct 24, 2023
…nchronous modal setup
QuintonJason
force-pushed
the
docs/modal
branch
from
e711328 to
e98ceec
Compare
QuintonJason
changed the title
QuintonJason
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Form Modal documentation to better explain props in Rails.
Screenshots
Testing in
sage-libTesting in
kajabi-productsRelated