Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSS-479] Sortable - Content Width Issue #1820

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

anechol
Copy link
Contributor

@anechol anechol commented Oct 18, 2023

Description

Fixes an issue with the truncation of the title dictating the width of the content. Both the title and subtitle should be able to truncate independently of the other and the content area should take up 100% of the available space.

Screenshots

Before After
Screenshot 2023-10-17 at 5 00 06 PM Screenshot 2023-10-17 at 4 48 24 PM
Screenshot 2023-10-17 at 4 59 56 PM Screenshot 2023-10-17 at 4 48 43 PM

Testing in sage-lib

  1. Navigate to Sortable
  2. In browser dev tools, add extra text to the subtitle
  3. Check that the content area expands the full length of the grid track
  4. Check that subtitle can expand independently from the title

Testing in kajabi-products

(MEDIUM) Fixes an issue with the truncation of the title dictating the width of the content. Both the title and subtitle should be able to truncate independently of the other and the content area should take up 100% of the available space. Minor UI update but touches multiple parts of the app.

Related

DSS-479

@anechol anechol requested a review from a team October 18, 2023 14:14
@anechol anechol self-assigned this Oct 18, 2023
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pixelflips pixelflips requested a review from a team October 18, 2023 14:36
@anechol anechol merged commit 995c83c into develop Oct 18, 2023
4 checks passed
@anechol anechol deleted the sortable-width-bug branch October 18, 2023 15:54
@anechol anechol mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants