-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove heroku artifacts #1865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
@voodooGQ Can you confirm if we still need the following files?
If we don't I'll delete them as well. Thank you |
@ju-Skinner feel free to delete those 3 files, they are all Heroku related! |
voodooGQ
approved these changes
Feb 27, 2024
monicawheeler
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Merged
ju-Skinner
added a commit
that referenced
this pull request
Mar 12, 2024
* chore: remove heroku artifacts (#1865) * chore: remove heroku artifacts * chore: remove additional heroku files --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> * fix(hero): adds missing prop to allow custom class names * fix(modal): move scrollbars to the edge of the container when scrollable * style(modal): use padding instead of margin to move scrollbars away from content * style(modal): update order of props * style(modal): remove overflow hidden --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> Co-authored-by: Ashley Echols <ashley.echols@kajabi.com> Co-authored-by: Quinton Jason <quinton.jason@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the recent changings to migrate from Heroku to EKS, this PR removes leftover Heroku artifacts.