Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove heroku artifacts #1865

Merged
merged 2 commits into from
Feb 27, 2024
Merged

chore: remove heroku artifacts #1865

merged 2 commits into from
Feb 27, 2024

Conversation

ju-Skinner
Copy link
Collaborator

Description

With the recent changings to migrate from Heroku to EKS, this PR removes leftover Heroku artifacts.

@ju-Skinner ju-Skinner self-assigned this Feb 27, 2024
Copy link
Contributor

github-actions bot commented Feb 27, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@ju-Skinner ju-Skinner requested review from voodooGQ and a team February 27, 2024 14:49
@ju-Skinner
Copy link
Collaborator Author

@voodooGQ Can you confirm if we still need the following files?

  1. bin/compile -https://github.com/Kajabi/sage-lib/blob/1f3b8e38db39ebb1c441d216e76a959f59bb41e0/bin/compile
  2. bin/detect - https://github.com/Kajabi/sage-lib/blob/1f3b8e38db39ebb1c441d216e76a959f59bb41e0/bin/detect
  3. bin/release - https://github.com/Kajabi/sage-lib/blob/1f3b8e38db39ebb1c441d216e76a959f59bb41e0/bin/release

If we don't I'll delete them as well.

Thank you

@voodooGQ
Copy link
Collaborator

@ju-Skinner feel free to delete those 3 files, they are all Heroku related!

giphy

Copy link
Collaborator

@monicawheeler monicawheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ju-Skinner ju-Skinner merged commit bfab68f into develop Feb 27, 2024
6 checks passed
@ju-Skinner ju-Skinner deleted the chore/heroku-cleanup branch February 27, 2024 15:54
@ju-Skinner ju-Skinner mentioned this pull request Feb 27, 2024
ju-Skinner added a commit that referenced this pull request Mar 12, 2024
* chore: remove heroku artifacts (#1865)

* chore: remove heroku artifacts

* chore: remove additional heroku files

---------

Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>

* fix(hero): adds missing prop to allow custom class names

* fix(modal): move scrollbars to the edge of the container when scrollable

* style(modal): use padding instead of margin to move scrollbars away from content

* style(modal): update order of props

* style(modal): remove overflow hidden

---------

Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
Co-authored-by: Ashley Echols <ashley.echols@kajabi.com>
Co-authored-by: Quinton Jason <quinton.jason@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants