Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Version Relese #1892

Merged
merged 6 commits into from
May 31, 2024
Merged

Next Version Relese #1892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f07f65c
fix(dropdown): add check for el (#1885)
pixelflips May 9, 2024
412bf7b
chore: update browserslist dependency
monicawheeler May 15, 2024
7eadcaa
chore: remove empty package.json dependencies block
monicawheeler May 15, 2024
d5efb6e
Merge pull request #1887 from Kajabi/chore/dependency-update-browsers…
monicawheeler May 15, 2024
4cd1b72
chore: update node engines to support v20 (#1888)
ju-Skinner May 16, 2024
ea31830
fix(breadcrumbs): rails resolve has_back_icon bug (#1891)
QuintonJason May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/lint-test-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
env:
NODE_VERSION: ${{ matrix.node-version }}
run: |
if [[ $NODE_VERSION == '18' ]]; then
if (( $NODE_VERSION >= 18 )); then
NODE_OPTIONS=--openssl-legacy-provider npm install -g yarn
else
npm install -g yarn
Expand All @@ -34,7 +34,7 @@ jobs:
env:
NODE_VERSION: ${{ matrix.node-version }}
run: |
if [[ $NODE_VERSION == '18' ]]; then
if (( $NODE_VERSION >= 18 )); then
NODE_OPTIONS=--openssl-legacy-provider yarn install
else
yarn install
Expand All @@ -45,7 +45,7 @@ jobs:
env:
NODE_VERSION: ${{ matrix.node-version }}
run: |
if [[ $NODE_VERSION == '18' ]]; then
if (( $NODE_VERSION >= 18 )); then
NODE_OPTIONS=--openssl-legacy-provider yarn lint
else
yarn lint
Expand All @@ -55,7 +55,7 @@ jobs:
env:
NODE_VERSION: ${{ matrix.node-version }}
run: |
if [[ $NODE_VERSION == '18' ]]; then
if (( $NODE_VERSION >= 18 )); then
NODE_OPTIONS=--openssl-legacy-provider yarn test
else
yarn test
Expand All @@ -65,7 +65,7 @@ jobs:
env:
NODE_VERSION: ${{ matrix.node-version }}
run: |
if [[ $NODE_VERSION == '18' ]]; then
if (( $NODE_VERSION >= 18 )); then
NODE_OPTIONS=--openssl-legacy-provider yarn build
else
yarn build
Expand Down
5 changes: 3 additions & 2 deletions docs/lib/sage_rails/app/views/sage_components/_sage_breadcrumbs.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<%
has_back_icon = component.has_back_icon.present? ? component.has_back_icon : component.items.length() == 1
# The intent is to set this prop to false unless the has_back_icon prop is explicitly set
has_back_icon = component.has_back_icon.nil? ? component.items.length() == 1 : component.has_back_icon
is_progressbar = component.is_progressbar.present? && component.is_progressbar
%>
<nav
Expand Down Expand Up @@ -38,7 +39,7 @@ is_progressbar = component.is_progressbar.present? && component.is_progressbar
<i class="sage-breadcrumbs__icon sage-icon-arrow-left" aria-hidden="true"></i>
<% end %>
<%= component.items[0][:text] %>
</a>
</a>
</p>
<% end %>
</nav>
2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"test": "test"
},
"engines": {
"node": "16.x || 18.x",
"node": "16.x || 18.x || 20.x",
"npm": "8.x",
"yarn": "1.x"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/sage-assets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"sassdoc/*"
],
"engines": {
"node": "16.x || 18.x",
"node": "16.x || 18.x || 20.x",
"npm": "8.x",
"yarn": "1.x"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/sage-packs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"packs"
],
"engines": {
"node": "16.x || 18.x",
"node": "16.x || 18.x || 20.x",
"npm": "8.x",
"yarn": "1.x"
},
Expand Down
4 changes: 4 additions & 0 deletions packages/sage-react/lib/Dropdown/Dropdown.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ export const Dropdown = ({
let directionX = null;
let directionY = null;
const el = wrapperRef.current;

// if el is null, return
if (!el) return;

// Elements
const button = el;
const panel = el.lastElementChild;
Expand Down
2 changes: 1 addition & 1 deletion packages/sage-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"url": "https://github.com/Kajabi/sage-lib/issues"
},
"engines": {
"node": "16.x || 18.x",
"node": "16.x || 18.x || 20.x",
"npm": "8.x",
"yarn": "1.x"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/sage-system/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"dist/*"
],
"engines": {
"node": "16.x || 18.x",
"node": "16.x || 18.x || 20.x",
"npm": "8.x",
"yarn": "1.x"
},
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6198,9 +6198,9 @@ caniuse-api@^3.0.0:
lodash.uniq "^4.5.0"

caniuse-lite@^1.0.0, caniuse-lite@^1.0.30000981, caniuse-lite@^1.0.30001109, caniuse-lite@^1.0.30001370:
version "1.0.30001521"
resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001521.tgz"
integrity sha512-fnx1grfpEOvDGH+V17eccmNjucGUnCbP6KL+l5KqBIerp26WK/+RQ7CIDE37KGJjaPyqWXXlFUyKiWmvdNNKmQ==
version "1.0.30001618"
resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001618.tgz"
integrity sha512-p407+D1tIkDvsEAPS22lJxLQQaG8OTBEqo0KhzfABGk0TU4juBNDSfH0hyAp/HRyx+M8L17z/ltyhxh27FTfQg==

capital-case@^1.0.4:
version "1.0.4"
Expand Down
Loading