style(line-height): update line-height to have rem units #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ju-Skinner
reviewed
Aug 6, 2024
Comment on lines
+13
to
+21
| xs: rem(18px), | ||
| sm: rem(18px), | ||
| md: rem(20px), | ||
| lg: rem(20px), | ||
| xl: rem(22px), | ||
| 2xl: rem(26px), | ||
| 3xl: rem(28px), | ||
| 4xl: rem(32px), | ||
| 5xl: rem(36px), |
There was a problem hiding this comment.
What is the actual value of sm in this scenario?
There was a problem hiding this comment.
--sage-line-height-body-sm: 1.125rem; for that one
ju-Skinner
approved these changes
Aug 7, 2024
ju-Skinner
changed the title
ju-Skinner
pushed a commit
that referenced
this pull request
Aug 7, 2024
ju-Skinner
pushed a commit
that referenced
this pull request
Aug 8, 2024
ju-Skinner
pushed a commit
that referenced
this pull request
Aug 12, 2024
ju-Skinner
pushed a commit
that referenced
this pull request
Aug 13, 2024
ju-Skinner
pushed a commit
that referenced
this pull request
Aug 16, 2024
ju-Skinner
pushed a commit
that referenced
this pull request
Aug 19, 2024
ju-Skinner
pushed a commit
that referenced
this pull request
Aug 21, 2024
ju-Skinner
pushed a commit
that referenced
this pull request
Sep 3, 2024
ju-Skinner
pushed a commit
that referenced
this pull request
Sep 3, 2024
ju-Skinner
pushed a commit
that referenced
this pull request
Sep 16, 2024
ju-Skinner
pushed a commit
that referenced
this pull request
Oct 1, 2024
ci: update rebrand mercury workflow for deployments revert(font-weight): combine font-weights back to *00 based fix: DSS-752 style(letter-spacing): updates to letter spacing for medium and smaller (#1922) fix: DSS-747 Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update body-xs to 12px (#1926) refactor: removes page scope empty state and updates styles style: adds styles for Icon Card for default and compact variants style: adds gradient to icon card and empty state docs: removes unneeded examples and adds new props refactor: removes gradient refactor: renames scope prop to size chore: fixes Story name refactor: adds background color to icon docs: updates Empty States docs pages for Rails and React docs: updates React component description with better clarity chore: fixes linting issues chore: removes unneeded gradient references style(alert): adjust small variant icon alignment (#1930) style(checkbox): adjust checkbox margin for alignment (#1931) style(dropdown): add display flex to dropdown trigger (#1934) * style(dropdown): add display flex to dropdown trigger * style(dropdown): reorder css property style(badge): correct interactive icon size (#1935) style(line-height): update line-height to have rem units (#1933) fix(p): remove adjacent p tag spacing (#1936) fix: add white background color to box-like elements * fix(box-shadow): update box shadow token value * fix(box like components): add white background and md box shadow * fix(container): remove color and shadow from container * fix(css): updated order * fix(frame): update to fix background color with nested frames * fix(frame): add white background to bordered variant chore: adds scope prop to address spec failures chore: fixes syntax error fix: add panel box-shadow (#1944) * fix: add box-shadow to panel * fix: remove box-shadow from inner card and panels fix: updates placeholder assets & styles (#1947) * fix: add new image assets * style: adjust page heading image bg color * fix: add new image assets for storybook * fix: convert unsplash images to placeholders * fix: convert unsplash images to small placeholder * fix: hello linter my old friend * fix: update image in empty state fix: update line-height tokens (#1951) fix: update box shadows (#1952) * fix: update box shadows * fix: add space after comma ci: revert rebrand-mercury-rising back to original workflow this is done since release-deploy has been fixed. We hopes this solves this branch from not deploying properly in staging style(pagination): remove background color (#1956) style(choice): correct icon alignment (#1957) * style(choice): remove incorrect margin styles * docs(choice): add additional example without subtext fix(sortable): update template columns (#1960) fix(frame): add box shadow to bordered frame (#1958) style(tab): adjust tab underline variable value (#1959) chore: update pine-ds/icons to latets version fix: updates conditionals to make image optional (#1965) style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter style: change the active tab color to mercury 50 (#1969) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: focus state updates (#1970) * style: update sage-focus-ring mixin * style: update focus-outline colors * fix: removes duplicate focus ring * style: update focus colors and sizing * style: adjust tab focus * fix: replace named color for linter style(alert): add borders (#1972) style(progress): update the default fill color to mercury-50 (#1971) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change border radius to 9999px (#1973) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update spacer to use logical properties (#1968) style(button): change the colors for the accent variant to be purple (#1974) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> feature(loader): change loader to new behavior and colors (#1975) * feat(loader-rails): change the loader animation and fill color * feat(loader-react): change the loader animation and fill color * style(loader): change timing to 1.5s per convo with design team --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: updates button font family style: add Faire Spring font family (#1980) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change button font-weight to med (500) (#1984) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> fix(button): loading button wasn't animating, updated svg in button-spinner.js (#1987) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
ju-Skinner
pushed a commit
that referenced
this pull request
Oct 2, 2024
ci: update rebrand mercury workflow for deployments revert(font-weight): combine font-weights back to *00 based fix: DSS-752 style(letter-spacing): updates to letter spacing for medium and smaller (#1922) fix: DSS-747 Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update body-xs to 12px (#1926) refactor: removes page scope empty state and updates styles style: adds styles for Icon Card for default and compact variants style: adds gradient to icon card and empty state docs: removes unneeded examples and adds new props refactor: removes gradient refactor: renames scope prop to size chore: fixes Story name refactor: adds background color to icon docs: updates Empty States docs pages for Rails and React docs: updates React component description with better clarity chore: fixes linting issues chore: removes unneeded gradient references style(alert): adjust small variant icon alignment (#1930) style(checkbox): adjust checkbox margin for alignment (#1931) style(dropdown): add display flex to dropdown trigger (#1934) * style(dropdown): add display flex to dropdown trigger * style(dropdown): reorder css property style(badge): correct interactive icon size (#1935) style(line-height): update line-height to have rem units (#1933) fix(p): remove adjacent p tag spacing (#1936) fix: add white background color to box-like elements * fix(box-shadow): update box shadow token value * fix(box like components): add white background and md box shadow * fix(container): remove color and shadow from container * fix(css): updated order * fix(frame): update to fix background color with nested frames * fix(frame): add white background to bordered variant chore: adds scope prop to address spec failures chore: fixes syntax error fix: add panel box-shadow (#1944) * fix: add box-shadow to panel * fix: remove box-shadow from inner card and panels fix: updates placeholder assets & styles (#1947) * fix: add new image assets * style: adjust page heading image bg color * fix: add new image assets for storybook * fix: convert unsplash images to placeholders * fix: convert unsplash images to small placeholder * fix: hello linter my old friend * fix: update image in empty state fix: update line-height tokens (#1951) fix: update box shadows (#1952) * fix: update box shadows * fix: add space after comma ci: revert rebrand-mercury-rising back to original workflow this is done since release-deploy has been fixed. We hopes this solves this branch from not deploying properly in staging style(pagination): remove background color (#1956) style(choice): correct icon alignment (#1957) * style(choice): remove incorrect margin styles * docs(choice): add additional example without subtext fix(sortable): update template columns (#1960) fix(frame): add box shadow to bordered frame (#1958) style(tab): adjust tab underline variable value (#1959) chore: update pine-ds/icons to latets version fix: updates conditionals to make image optional (#1965) style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter style: change the active tab color to mercury 50 (#1969) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: focus state updates (#1970) * style: update sage-focus-ring mixin * style: update focus-outline colors * fix: removes duplicate focus ring * style: update focus colors and sizing * style: adjust tab focus * fix: replace named color for linter style(alert): add borders (#1972) style(progress): update the default fill color to mercury-50 (#1971) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change border radius to 9999px (#1973) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update spacer to use logical properties (#1968) style(button): change the colors for the accent variant to be purple (#1974) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> feature(loader): change loader to new behavior and colors (#1975) * feat(loader-rails): change the loader animation and fill color * feat(loader-react): change the loader animation and fill color * style(loader): change timing to 1.5s per convo with design team --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: updates button font family style: add Faire Spring font family (#1980) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change button font-weight to med (500) (#1984) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> fix(button): loading button wasn't animating, updated svg in button-spinner.js (#1987) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
ju-Skinner
pushed a commit
that referenced
this pull request
Oct 8, 2024
ci: update rebrand mercury workflow for deployments revert(font-weight): combine font-weights back to *00 based fix: DSS-752 style(letter-spacing): updates to letter spacing for medium and smaller (#1922) fix: DSS-747 Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update body-xs to 12px (#1926) refactor: removes page scope empty state and updates styles style: adds styles for Icon Card for default and compact variants style: adds gradient to icon card and empty state docs: removes unneeded examples and adds new props refactor: removes gradient refactor: renames scope prop to size chore: fixes Story name refactor: adds background color to icon docs: updates Empty States docs pages for Rails and React docs: updates React component description with better clarity chore: fixes linting issues chore: removes unneeded gradient references style(alert): adjust small variant icon alignment (#1930) style(checkbox): adjust checkbox margin for alignment (#1931) style(dropdown): add display flex to dropdown trigger (#1934) * style(dropdown): add display flex to dropdown trigger * style(dropdown): reorder css property style(badge): correct interactive icon size (#1935) style(line-height): update line-height to have rem units (#1933) fix(p): remove adjacent p tag spacing (#1936) fix: add white background color to box-like elements * fix(box-shadow): update box shadow token value * fix(box like components): add white background and md box shadow * fix(container): remove color and shadow from container * fix(css): updated order * fix(frame): update to fix background color with nested frames * fix(frame): add white background to bordered variant chore: adds scope prop to address spec failures chore: fixes syntax error fix: add panel box-shadow (#1944) * fix: add box-shadow to panel * fix: remove box-shadow from inner card and panels fix: updates placeholder assets & styles (#1947) * fix: add new image assets * style: adjust page heading image bg color * fix: add new image assets for storybook * fix: convert unsplash images to placeholders * fix: convert unsplash images to small placeholder * fix: hello linter my old friend * fix: update image in empty state fix: update line-height tokens (#1951) fix: update box shadows (#1952) * fix: update box shadows * fix: add space after comma ci: revert rebrand-mercury-rising back to original workflow this is done since release-deploy has been fixed. We hopes this solves this branch from not deploying properly in staging style(pagination): remove background color (#1956) style(choice): correct icon alignment (#1957) * style(choice): remove incorrect margin styles * docs(choice): add additional example without subtext fix(sortable): update template columns (#1960) fix(frame): add box shadow to bordered frame (#1958) style(tab): adjust tab underline variable value (#1959) chore: update pine-ds/icons to latets version fix: updates conditionals to make image optional (#1965) style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter style: change the active tab color to mercury 50 (#1969) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: focus state updates (#1970) * style: update sage-focus-ring mixin * style: update focus-outline colors * fix: removes duplicate focus ring * style: update focus colors and sizing * style: adjust tab focus * fix: replace named color for linter style(alert): add borders (#1972) style(progress): update the default fill color to mercury-50 (#1971) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change border radius to 9999px (#1973) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update spacer to use logical properties (#1968) style(button): change the colors for the accent variant to be purple (#1974) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> feature(loader): change loader to new behavior and colors (#1975) * feat(loader-rails): change the loader animation and fill color * feat(loader-react): change the loader animation and fill color * style(loader): change timing to 1.5s per convo with design team --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: updates button font family style: add Faire Spring font family (#1980) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change button font-weight to med (500) (#1984) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> fix(button): loading button wasn't animating, updated svg in button-spinner.js (#1987) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
ju-Skinner
pushed a commit
that referenced
this pull request
Oct 14, 2024
BREAKING CHANGE: This is a breaking change due to the rebranding effort ci: update rebrand mercury workflow for deployments revert(font-weight): combine font-weights back to *00 based fix: DSS-752 style(letter-spacing): updates to letter spacing for medium and smaller (#1922) fix: DSS-747 Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update body-xs to 12px (#1926) refactor: removes page scope empty state and updates styles style: adds styles for Icon Card for default and compact variants style: adds gradient to icon card and empty state docs: removes unneeded examples and adds new props refactor: removes gradient refactor: renames scope prop to size chore: fixes Story name refactor: adds background color to icon docs: updates Empty States docs pages for Rails and React docs: updates React component description with better clarity chore: fixes linting issues chore: removes unneeded gradient references style(alert): adjust small variant icon alignment (#1930) style(checkbox): adjust checkbox margin for alignment (#1931) style(dropdown): add display flex to dropdown trigger (#1934) * style(dropdown): add display flex to dropdown trigger * style(dropdown): reorder css property style(badge): correct interactive icon size (#1935) style(line-height): update line-height to have rem units (#1933) fix(p): remove adjacent p tag spacing (#1936) fix: add white background color to box-like elements * fix(box-shadow): update box shadow token value * fix(box like components): add white background and md box shadow * fix(container): remove color and shadow from container * fix(css): updated order * fix(frame): update to fix background color with nested frames * fix(frame): add white background to bordered variant chore: adds scope prop to address spec failures chore: fixes syntax error fix: add panel box-shadow (#1944) * fix: add box-shadow to panel * fix: remove box-shadow from inner card and panels fix: updates placeholder assets & styles (#1947) * fix: add new image assets * style: adjust page heading image bg color * fix: add new image assets for storybook * fix: convert unsplash images to placeholders * fix: convert unsplash images to small placeholder * fix: hello linter my old friend * fix: update image in empty state fix: update line-height tokens (#1951) fix: update box shadows (#1952) * fix: update box shadows * fix: add space after comma ci: revert rebrand-mercury-rising back to original workflow this is done since release-deploy has been fixed. We hopes this solves this branch from not deploying properly in staging style(pagination): remove background color (#1956) style(choice): correct icon alignment (#1957) * style(choice): remove incorrect margin styles * docs(choice): add additional example without subtext fix(sortable): update template columns (#1960) fix(frame): add box shadow to bordered frame (#1958) style(tab): adjust tab underline variable value (#1959) chore: update pine-ds/icons to latets version fix: updates conditionals to make image optional (#1965) style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter style: change the active tab color to mercury 50 (#1969) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: focus state updates (#1970) * style: update sage-focus-ring mixin * style: update focus-outline colors * fix: removes duplicate focus ring * style: update focus colors and sizing * style: adjust tab focus * fix: replace named color for linter style(alert): add borders (#1972) style(progress): update the default fill color to mercury-50 (#1971) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change border radius to 9999px (#1973) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update spacer to use logical properties (#1968) style(button): change the colors for the accent variant to be purple (#1974) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> feature(loader): change loader to new behavior and colors (#1975) * feat(loader-rails): change the loader animation and fill color * feat(loader-react): change the loader animation and fill color * style(loader): change timing to 1.5s per convo with design team --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: updates button font family style: add Faire Spring font family (#1980) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change button font-weight to med (500) (#1984) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> fix(button): loading button wasn't animating, updated svg in button-spinner.js (#1987) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> feat: v1.1 rebrand style: update size of font in table (#1986) style: convert focus to focus-within (#1985) style: update color token name 3 digits (#1955) * fix(frame): add box shadow to bordered frame (#1958) * style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter * fix: change legacy colors to mapped values ie red 500 to red 95 * fix: remove old 100 tokens * fix: add 0 to make token 3 digits * fix: add red color classes * fix: add 0 to green color token names * fix: add 0 to blue color token names * fix: add 0 to mercury color token names * fix: add 0 to yellow color token names * fix: add 0 to purple color token names * fix: update grey color token names to 3 digits * fix: update react green colors * fix: update react purple colors * fix: update red in jsx and erb * fix: update orange color token to mercury * fix: update charcoal color token to upper greys * fix: update grey color token to lower greys * fix: add options for default color values * chore: remove whitespace * fix: self review fix grey 300 and grey 400 in css * Revert "fix: self review fix grey 300 and grey 400 in css" This reverts commit 2ae5967. * Revert "fix: update grey color token to lower greys" This reverts commit 69f8706. * fix: update grey color token to lower greys * Revert "fix: update grey color token to lower greys" This reverts commit 2f43f1d. * style: update purple color token to use three digits * style: update additional 2 digit token value to 3 digit token values * style: added zero to mercury 30 * style: update templating to wrap 050 values in single-quotes * style(breadcrumbs): change charcoal 400 to grey 900 * fix: update gray to grey instances --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update hover color (#1991) style: adjust box shadow (#1992) style: update hint font-size (#1994) fix: adjust token color (#1995) fix: adjust token color (#1997) docs: fix foundations color page fix: correct progress color tokens (#1998) * fix: correct color tokens * docs: update value in react story fix: update token value (#1999)
ju-Skinner
added a commit
that referenced
this pull request
Oct 14, 2024
* feat!(rebrand): mercury-rising rebrand effort BREAKING CHANGE: This is a breaking change due to the rebranding effort ci: update rebrand mercury workflow for deployments revert(font-weight): combine font-weights back to *00 based fix: DSS-752 style(letter-spacing): updates to letter spacing for medium and smaller (#1922) fix: DSS-747 Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update body-xs to 12px (#1926) refactor: removes page scope empty state and updates styles style: adds styles for Icon Card for default and compact variants style: adds gradient to icon card and empty state docs: removes unneeded examples and adds new props refactor: removes gradient refactor: renames scope prop to size chore: fixes Story name refactor: adds background color to icon docs: updates Empty States docs pages for Rails and React docs: updates React component description with better clarity chore: fixes linting issues chore: removes unneeded gradient references style(alert): adjust small variant icon alignment (#1930) style(checkbox): adjust checkbox margin for alignment (#1931) style(dropdown): add display flex to dropdown trigger (#1934) * style(dropdown): add display flex to dropdown trigger * style(dropdown): reorder css property style(badge): correct interactive icon size (#1935) style(line-height): update line-height to have rem units (#1933) fix(p): remove adjacent p tag spacing (#1936) fix: add white background color to box-like elements * fix(box-shadow): update box shadow token value * fix(box like components): add white background and md box shadow * fix(container): remove color and shadow from container * fix(css): updated order * fix(frame): update to fix background color with nested frames * fix(frame): add white background to bordered variant chore: adds scope prop to address spec failures chore: fixes syntax error fix: add panel box-shadow (#1944) * fix: add box-shadow to panel * fix: remove box-shadow from inner card and panels fix: updates placeholder assets & styles (#1947) * fix: add new image assets * style: adjust page heading image bg color * fix: add new image assets for storybook * fix: convert unsplash images to placeholders * fix: convert unsplash images to small placeholder * fix: hello linter my old friend * fix: update image in empty state fix: update line-height tokens (#1951) fix: update box shadows (#1952) * fix: update box shadows * fix: add space after comma ci: revert rebrand-mercury-rising back to original workflow this is done since release-deploy has been fixed. We hopes this solves this branch from not deploying properly in staging style(pagination): remove background color (#1956) style(choice): correct icon alignment (#1957) * style(choice): remove incorrect margin styles * docs(choice): add additional example without subtext fix(sortable): update template columns (#1960) fix(frame): add box shadow to bordered frame (#1958) style(tab): adjust tab underline variable value (#1959) chore: update pine-ds/icons to latets version fix: updates conditionals to make image optional (#1965) style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter style: change the active tab color to mercury 50 (#1969) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: focus state updates (#1970) * style: update sage-focus-ring mixin * style: update focus-outline colors * fix: removes duplicate focus ring * style: update focus colors and sizing * style: adjust tab focus * fix: replace named color for linter style(alert): add borders (#1972) style(progress): update the default fill color to mercury-50 (#1971) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change border radius to 9999px (#1973) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update spacer to use logical properties (#1968) style(button): change the colors for the accent variant to be purple (#1974) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> feature(loader): change loader to new behavior and colors (#1975) * feat(loader-rails): change the loader animation and fill color * feat(loader-react): change the loader animation and fill color * style(loader): change timing to 1.5s per convo with design team --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: updates button font family style: add Faire Spring font family (#1980) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change button font-weight to med (500) (#1984) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> fix(button): loading button wasn't animating, updated svg in button-spinner.js (#1987) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> feat: v1.1 rebrand style: update size of font in table (#1986) style: convert focus to focus-within (#1985) style: update color token name 3 digits (#1955) * fix(frame): add box shadow to bordered frame (#1958) * style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter * fix: change legacy colors to mapped values ie red 500 to red 95 * fix: remove old 100 tokens * fix: add 0 to make token 3 digits * fix: add red color classes * fix: add 0 to green color token names * fix: add 0 to blue color token names * fix: add 0 to mercury color token names * fix: add 0 to yellow color token names * fix: add 0 to purple color token names * fix: update grey color token names to 3 digits * fix: update react green colors * fix: update react purple colors * fix: update red in jsx and erb * fix: update orange color token to mercury * fix: update charcoal color token to upper greys * fix: update grey color token to lower greys * fix: add options for default color values * chore: remove whitespace * fix: self review fix grey 300 and grey 400 in css * Revert "fix: self review fix grey 300 and grey 400 in css" This reverts commit 2ae5967. * Revert "fix: update grey color token to lower greys" This reverts commit 69f8706. * fix: update grey color token to lower greys * Revert "fix: update grey color token to lower greys" This reverts commit 2f43f1d. * style: update purple color token to use three digits * style: update additional 2 digit token value to 3 digit token values * style: added zero to mercury 30 * style: update templating to wrap 050 values in single-quotes * style(breadcrumbs): change charcoal 400 to grey 900 * fix: update gray to grey instances --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update hover color (#1991) style: adjust box shadow (#1992) style: update hint font-size (#1994) fix: adjust token color (#1995) fix: adjust token color (#1997) docs: fix foundations color page fix: correct progress color tokens (#1998) * fix: correct color tokens * docs: update value in react story fix: update token value (#1999) * ci: cleanup and prepare for release * chore: bump @pine-ds/icons to 8.6.0 --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
QuintonJason
pushed a commit
that referenced
this pull request
Oct 16, 2024
ci: update rebrand mercury workflow for deployments revert(font-weight): combine font-weights back to *00 based fix: DSS-752 style(letter-spacing): updates to letter spacing for medium and smaller (#1922) fix: DSS-747 Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update body-xs to 12px (#1926) refactor: removes page scope empty state and updates styles style: adds styles for Icon Card for default and compact variants style: adds gradient to icon card and empty state docs: removes unneeded examples and adds new props refactor: removes gradient refactor: renames scope prop to size chore: fixes Story name refactor: adds background color to icon docs: updates Empty States docs pages for Rails and React docs: updates React component description with better clarity chore: fixes linting issues chore: removes unneeded gradient references style(alert): adjust small variant icon alignment (#1930) style(checkbox): adjust checkbox margin for alignment (#1931) style(dropdown): add display flex to dropdown trigger (#1934) * style(dropdown): add display flex to dropdown trigger * style(dropdown): reorder css property style(badge): correct interactive icon size (#1935) style(line-height): update line-height to have rem units (#1933) fix(p): remove adjacent p tag spacing (#1936) fix: add white background color to box-like elements * fix(box-shadow): update box shadow token value * fix(box like components): add white background and md box shadow * fix(container): remove color and shadow from container * fix(css): updated order * fix(frame): update to fix background color with nested frames * fix(frame): add white background to bordered variant chore: adds scope prop to address spec failures chore: fixes syntax error fix: add panel box-shadow (#1944) * fix: add box-shadow to panel * fix: remove box-shadow from inner card and panels fix: updates placeholder assets & styles (#1947) * fix: add new image assets * style: adjust page heading image bg color * fix: add new image assets for storybook * fix: convert unsplash images to placeholders * fix: convert unsplash images to small placeholder * fix: hello linter my old friend * fix: update image in empty state fix: update line-height tokens (#1951) fix: update box shadows (#1952) * fix: update box shadows * fix: add space after comma ci: revert rebrand-mercury-rising back to original workflow this is done since release-deploy has been fixed. We hopes this solves this branch from not deploying properly in staging style(pagination): remove background color (#1956) style(choice): correct icon alignment (#1957) * style(choice): remove incorrect margin styles * docs(choice): add additional example without subtext fix(sortable): update template columns (#1960) fix(frame): add box shadow to bordered frame (#1958) style(tab): adjust tab underline variable value (#1959) chore: update pine-ds/icons to latets version fix: updates conditionals to make image optional (#1965) style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter style: change the active tab color to mercury 50 (#1969) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: focus state updates (#1970) * style: update sage-focus-ring mixin * style: update focus-outline colors * fix: removes duplicate focus ring * style: update focus colors and sizing * style: adjust tab focus * fix: replace named color for linter style(alert): add borders (#1972) style(progress): update the default fill color to mercury-50 (#1971) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change border radius to 9999px (#1973) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update spacer to use logical properties (#1968) style(button): change the colors for the accent variant to be purple (#1974) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> feature(loader): change loader to new behavior and colors (#1975) * feat(loader-rails): change the loader animation and fill color * feat(loader-react): change the loader animation and fill color * style(loader): change timing to 1.5s per convo with design team --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: updates button font family style: add Faire Spring font family (#1980) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change button font-weight to med (500) (#1984) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> fix(button): loading button wasn't animating, updated svg in button-spinner.js (#1987) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
QuintonJason
pushed a commit
that referenced
this pull request
Oct 18, 2024
ci: update rebrand mercury workflow for deployments revert(font-weight): combine font-weights back to *00 based fix: DSS-752 style(letter-spacing): updates to letter spacing for medium and smaller (#1922) fix: DSS-747 Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update body-xs to 12px (#1926) refactor: removes page scope empty state and updates styles style: adds styles for Icon Card for default and compact variants style: adds gradient to icon card and empty state docs: removes unneeded examples and adds new props refactor: removes gradient refactor: renames scope prop to size chore: fixes Story name refactor: adds background color to icon docs: updates Empty States docs pages for Rails and React docs: updates React component description with better clarity chore: fixes linting issues chore: removes unneeded gradient references style(alert): adjust small variant icon alignment (#1930) style(checkbox): adjust checkbox margin for alignment (#1931) style(dropdown): add display flex to dropdown trigger (#1934) * style(dropdown): add display flex to dropdown trigger * style(dropdown): reorder css property style(badge): correct interactive icon size (#1935) style(line-height): update line-height to have rem units (#1933) fix(p): remove adjacent p tag spacing (#1936) fix: add white background color to box-like elements * fix(box-shadow): update box shadow token value * fix(box like components): add white background and md box shadow * fix(container): remove color and shadow from container * fix(css): updated order * fix(frame): update to fix background color with nested frames * fix(frame): add white background to bordered variant chore: adds scope prop to address spec failures chore: fixes syntax error fix: add panel box-shadow (#1944) * fix: add box-shadow to panel * fix: remove box-shadow from inner card and panels fix: updates placeholder assets & styles (#1947) * fix: add new image assets * style: adjust page heading image bg color * fix: add new image assets for storybook * fix: convert unsplash images to placeholders * fix: convert unsplash images to small placeholder * fix: hello linter my old friend * fix: update image in empty state fix: update line-height tokens (#1951) fix: update box shadows (#1952) * fix: update box shadows * fix: add space after comma ci: revert rebrand-mercury-rising back to original workflow this is done since release-deploy has been fixed. We hopes this solves this branch from not deploying properly in staging style(pagination): remove background color (#1956) style(choice): correct icon alignment (#1957) * style(choice): remove incorrect margin styles * docs(choice): add additional example without subtext fix(sortable): update template columns (#1960) fix(frame): add box shadow to bordered frame (#1958) style(tab): adjust tab underline variable value (#1959) chore: update pine-ds/icons to latets version fix: updates conditionals to make image optional (#1965) style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter style: change the active tab color to mercury 50 (#1969) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: focus state updates (#1970) * style: update sage-focus-ring mixin * style: update focus-outline colors * fix: removes duplicate focus ring * style: update focus colors and sizing * style: adjust tab focus * fix: replace named color for linter style(alert): add borders (#1972) style(progress): update the default fill color to mercury-50 (#1971) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change border radius to 9999px (#1973) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update spacer to use logical properties (#1968) style(button): change the colors for the accent variant to be purple (#1974) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> feature(loader): change loader to new behavior and colors (#1975) * feat(loader-rails): change the loader animation and fill color * feat(loader-react): change the loader animation and fill color * style(loader): change timing to 1.5s per convo with design team --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: updates button font family style: add Faire Spring font family (#1980) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change button font-weight to med (500) (#1984) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> fix(button): loading button wasn't animating, updated svg in button-spinner.js (#1987) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
QuintonJason
added a commit
that referenced
this pull request
Oct 18, 2024
* feat!(rebrand): mercury-rising rebrand effort ci: update rebrand mercury workflow for deployments revert(font-weight): combine font-weights back to *00 based fix: DSS-752 style(letter-spacing): updates to letter spacing for medium and smaller (#1922) fix: DSS-747 Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update body-xs to 12px (#1926) refactor: removes page scope empty state and updates styles style: adds styles for Icon Card for default and compact variants style: adds gradient to icon card and empty state docs: removes unneeded examples and adds new props refactor: removes gradient refactor: renames scope prop to size chore: fixes Story name refactor: adds background color to icon docs: updates Empty States docs pages for Rails and React docs: updates React component description with better clarity chore: fixes linting issues chore: removes unneeded gradient references style(alert): adjust small variant icon alignment (#1930) style(checkbox): adjust checkbox margin for alignment (#1931) style(dropdown): add display flex to dropdown trigger (#1934) * style(dropdown): add display flex to dropdown trigger * style(dropdown): reorder css property style(badge): correct interactive icon size (#1935) style(line-height): update line-height to have rem units (#1933) fix(p): remove adjacent p tag spacing (#1936) fix: add white background color to box-like elements * fix(box-shadow): update box shadow token value * fix(box like components): add white background and md box shadow * fix(container): remove color and shadow from container * fix(css): updated order * fix(frame): update to fix background color with nested frames * fix(frame): add white background to bordered variant chore: adds scope prop to address spec failures chore: fixes syntax error fix: add panel box-shadow (#1944) * fix: add box-shadow to panel * fix: remove box-shadow from inner card and panels fix: updates placeholder assets & styles (#1947) * fix: add new image assets * style: adjust page heading image bg color * fix: add new image assets for storybook * fix: convert unsplash images to placeholders * fix: convert unsplash images to small placeholder * fix: hello linter my old friend * fix: update image in empty state fix: update line-height tokens (#1951) fix: update box shadows (#1952) * fix: update box shadows * fix: add space after comma ci: revert rebrand-mercury-rising back to original workflow this is done since release-deploy has been fixed. We hopes this solves this branch from not deploying properly in staging style(pagination): remove background color (#1956) style(choice): correct icon alignment (#1957) * style(choice): remove incorrect margin styles * docs(choice): add additional example without subtext fix(sortable): update template columns (#1960) fix(frame): add box shadow to bordered frame (#1958) style(tab): adjust tab underline variable value (#1959) chore: update pine-ds/icons to latets version fix: updates conditionals to make image optional (#1965) style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter style: change the active tab color to mercury 50 (#1969) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: focus state updates (#1970) * style: update sage-focus-ring mixin * style: update focus-outline colors * fix: removes duplicate focus ring * style: update focus colors and sizing * style: adjust tab focus * fix: replace named color for linter style(alert): add borders (#1972) style(progress): update the default fill color to mercury-50 (#1971) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change border radius to 9999px (#1973) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: update spacer to use logical properties (#1968) style(button): change the colors for the accent variant to be purple (#1974) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> feature(loader): change loader to new behavior and colors (#1975) * feat(loader-rails): change the loader animation and fill color * feat(loader-react): change the loader animation and fill color * style(loader): change timing to 1.5s per convo with design team --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style: updates button font family style: add Faire Spring font family (#1980) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> style(button): change button font-weight to med (500) (#1984) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> fix(button): loading button wasn't animating, updated svg in button-spinner.js (#1987) Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> * style: update color token name 3 digits (#1955) * fix(frame): add box shadow to bordered frame (#1958) * style: remove border from box like elements with box shadows (#1967) * style: add shadow to frame * style: remove border from box-like elements * chore: remove white space for linter * fix: change legacy colors to mapped values ie red 500 to red 95 * fix: remove old 100 tokens * fix: add 0 to make token 3 digits * fix: add red color classes * fix: add 0 to green color token names * fix: add 0 to blue color token names * fix: add 0 to mercury color token names * fix: add 0 to yellow color token names * fix: add 0 to purple color token names * fix: update grey color token names to 3 digits * fix: update react green colors * fix: update react purple colors * fix: update red in jsx and erb * fix: update orange color token to mercury * fix: update charcoal color token to upper greys * fix: update grey color token to lower greys * fix: add options for default color values * chore: remove whitespace * fix: self review fix grey 300 and grey 400 in css * Revert "fix: self review fix grey 300 and grey 400 in css" This reverts commit 2ae5967. * Revert "fix: update grey color token to lower greys" This reverts commit 69f8706. * fix: update grey color token to lower greys * Revert "fix: update grey color token to lower greys" This reverts commit 2f43f1d. * style: update purple color token to use three digits * style: update additional 2 digit token value to 3 digit token values * style: added zero to mercury 30 * style: update templating to wrap 050 values in single-quotes * style(breadcrumbs): change charcoal 400 to grey 900 * fix: update gray to grey instances --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com> * fix: add-border-to-inner-cards-and-panels * fix: clean up after rebase --------- Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding back units to the
line-heighttoken to ensure existing functions work as expectedScreenshots
Testing in
sage-libTesting in
kajabi-productsRelated
DSS-777