Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio: align radio with text, adjust indicator size to match spec #1937

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

monicawheeler
Copy link
Collaborator

@monicawheeler monicawheeler commented Aug 7, 2024

Description

Radio alignment with text is off center for the current implementation. This is for our current implementation, not the Rebrand.

Changes made

  • Changed size of indicator from 7px to 6px to align with the component specs
  • Removed margin-top for the radio

Screenshots for all three main browsers

Before After
before-browsers-radio after-browsers-radio

Testing in sage-lib

  1. Pull down PR
  2. Navigate to http://localhost:4000/pages/component/radio?tab=preview
  3. Verify the radio is aligned properly
  4. Review this PR to inform if my approach here is acceptable

Testing in kajabi-products

N/A - minor alignment update

Related

DSS-780

@monicawheeler monicawheeler self-assigned this Aug 7, 2024
@monicawheeler monicawheeler force-pushed the DSS-780-radio-adjustments branch from ca7f574 to 1a40677 Compare August 7, 2024 14:15
@monicawheeler monicawheeler requested a review from a team August 7, 2024 14:19
@monicawheeler monicawheeler force-pushed the DSS-780-radio-adjustments branch from 1a40677 to a61215e Compare August 7, 2024 16:12
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@monicawheeler monicawheeler merged commit 4f85b3f into develop Aug 7, 2024
7 checks passed
@monicawheeler monicawheeler deleted the DSS-780-radio-adjustments branch August 7, 2024 17:03
@pixelflips pixelflips mentioned this pull request Aug 7, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants