Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(expandablecard): update icon targeting #1941

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Aug 7, 2024

Description

https://kajabi.atlassian.net/browse/DSS-771

Problem

  1. Incorrect spacing between dropdown items.
  2. Icon rotation when dropdown was active.

Notes

I was unable to test this locally, due to Sage Bridge config, but @pixelflips and I paired to solve (99% Phillip).

Screenshots

Before After
image image

Testing in sage-lib

Small change, can go in general QE pass with other fixes.

Testing in kajabi-products

LOW Small change, can go in general QE pass with other fixes.

@FuturaExtraBold FuturaExtraBold self-assigned this Aug 7, 2024
@FuturaExtraBold FuturaExtraBold requested a review from a team August 7, 2024 23:39
@FuturaExtraBold FuturaExtraBold marked this pull request as ready for review August 8, 2024 16:07
Copy link
Member Author

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't hit the button, but LGTM!

Copy link
Collaborator

@monicawheeler monicawheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of Phillip 😄

@monicawheeler monicawheeler requested a review from a team August 8, 2024 17:05
@FuturaExtraBold FuturaExtraBold merged commit 57bd0fd into develop Aug 8, 2024
7 checks passed
@pixelflips pixelflips deleted the fix/expandable-card-icon-fixes branch August 14, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants