Update the workflow/Dockerfile for Storybook #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ju-Skinner and I spent many...many...many hours trying to get the Dockerfile to properly build-out the Storybook site. Despite our efforts we consistently ended up with missing files for seemingly no reason and therefore would get errors. Sage is becoming legacy, and junking a bunch more time into getting it to work "right" is counter-intuitive. Instead what we're going to do is build on the Github Actions runner and then just copy over the file to the Docker image as we know the "local builds" are working correctly.
This still has to be tested, but should accomplish our goals.