Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add focus outline override to components with focus-visible #2006

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: add focus outline override to components with focus-visible #2006

merged 1 commit into from
Oct 17, 2024

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Oct 16, 2024 •
edited
Loading

Description

Changing some components to focus-visible removed the outline:none for focus.
These updates bring back the focus to remove the outline caused by some default styles in KP that were previously overwritten.

Screenshots

Before After
Screenshot 2024-10-16 at 12 30 07 PM Screenshot 2024-10-16 at 12 30 18 PM

Testing in sage-lib

N/A

Testing in kajabi-products

  • Enable bridge with KP
  • Navigate around and confirm no outlines on buttons, radios, switches, etc on focus.
  • Verify focus-visible still functions as expected.
  1. (LOW) Adds focus outline override for various components.
    • Any buttons, switches, radios, etc...

Related

https://kajabi.atlassian.net/browse/DSS-1116

@pixelflips pixelflips self-assigned this Oct 16, 2024
@pixelflips pixelflips marked this pull request as ready for review October 16, 2024 19:35
@pixelflips pixelflips requested a review from a team October 16, 2024 19:48
@anechol anechol requested a review from a team October 16, 2024 20:58
ju-Skinner
ju-Skinner approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@ju-Skinner ju-Skinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before merging undo changes here packages/sage-assets/lib/stylesheets/components/_button.scss

packages/sage-assets/lib/stylesheets/components/_button.scss Show resolved Hide resolved
packages/sage-assets/lib/stylesheets/components/_button.scss Show resolved Hide resolved
@pixelflips pixelflips merged commit 7f233be into develop Oct 17, 2024
7 checks passed
@pixelflips pixelflips mentioned this pull request Oct 17, 2024
Merged
@pixelflips pixelflips deleted the fix/focus-state-adjustments branch October 17, 2024 21:12
ju-Skinner pushed a commit that referenced this pull request Oct 18, 2024
@pixelflips @kajabi-bot
fix: adds focus outline none back to components with focus visible ap…
b5632c3 
…plied (#2006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monicawheeler monicawheeler monicawheeler approved these changes

@anechol anechol anechol approved these changes

@ju-Skinner ju-Skinner ju-Skinner approved these changes

Assignees

@pixelflips pixelflips

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pixelflips @ju-Skinner @anechol @monicawheeler