Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: dropdown select has incorrect height applied #2017

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Oct 28, 2024

Description

The dropdown select variant has a height applied to help match other inputs, but it should be updated to min-height since this variant allows items to have custom content.

Updates fixed height to min-height to eliminate the issue.

Screenshots

Before After
Screenshot 2024-10-28 at 2 42 29 PM Screenshot 2024-10-28 at 2 44 19 PM

Testing in sage-lib

Navigate to Dropdown
Verify select variant updates properly when selecting an option.

Testing in kajabi-products

  1. (LOW) Adjusted the height of the dropdown select variant.
    • Coaching >> Group Coaching >> Scheduling (Scheduling preference dropdown.)

Related

https://kajabi.atlassian.net/browse/DSS-1138

@pixelflips pixelflips self-assigned this Oct 28, 2024
@pixelflips pixelflips marked this pull request as ready for review October 28, 2024 21:59
@pixelflips pixelflips requested a review from a team October 28, 2024 21:59
@monicawheeler monicawheeler requested a review from a team October 28, 2024 22:02
@pixelflips pixelflips merged commit 2dbccf4 into develop Oct 28, 2024
7 checks passed
@pixelflips pixelflips mentioned this pull request Oct 28, 2024
@pixelflips pixelflips deleted the style/select-dropdown-height-bug branch October 28, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants