Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to storage of user-specific data #104

Closed
leggewie opened this issue Jan 27, 2023 · 3 comments
Closed

improvements to storage of user-specific data #104

leggewie opened this issue Jan 27, 2023 · 3 comments

Comments

@leggewie
Copy link
Contributor

leggewie commented Jan 27, 2023

alright currently is inconsistent across platforms in where it stores its user-specific data. On Windows, things are stored under C:/Temp/ChromeProfile, for other platforms a folder User_Data in the current directory is used. This can lead to clutter and data-loss. I have a suspicion this is at least partially the reason why I see alright sometimes work and then a minute later (in a different directory?) fail (#103).

There is some convention and policy where this data ought to be stored. There is also a python library to do the heavy-lifting in the background. I will try and publish some code for review in the following days.

@Kalebu
Copy link
Owner

Kalebu commented Feb 3, 2023

Hello @leggewie

Not much thought was given in terms of where to store user's data and problems became more serious when you consider the multiplatform, I think this update will be incredibly useful, Are you still working on it ?

@leggewie
Copy link
Contributor Author

leggewie commented Feb 4, 2023

I kind of paused but I'm certainly still having it on my todo list

@leggewie
Copy link
Contributor Author

leggewie commented Feb 4, 2023

I have pushed a proposal.

Do we actually need the platform-specific coding or can we move everything (start-maximized, profile-directory) outside of the if-statement?

euriconicacio added a commit that referenced this issue Feb 6, 2023
switch to platformdirs. Closes: #104
leggewie added a commit to leggewie/alright that referenced this issue Oct 4, 2023
- add platformdirs python library to runtime dependencies
- use platformdirs' magic to determine where to store user data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants