MPC doc update to support PR#333 #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerlz
previously approved these changes
Jul 18, 2024
liampwll
reviewed
Jul 20, 2024
* Create homing_sensorless.md outline basics * Update homing_sensorless.md First pass brain dump * Update homing_sensorless.md * CleanUp For Review and Feedback Initial cleanup for review and feedback. * Minor update * Remove bed references and add TODO Remove bed references as no supported now and add TODO. * Misc changes * nightly check in add PTC chart, experimental bed, and temp wait macro sections. * Reformat everything Big reformat to make everything consistant. * fix markdown formating FML, markdown format fixes * Final touches for PR Grammar, typos, formatting fixes for PR * Delete docs/homing_sensorless.md How did this get in here. WTF
Update with missing parameters and improve section flow.
Change units on min ambient from C to C/s.
rogerlz
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big re-format and update to the MPC documentation to support MPC feature release to mainline in PR https://github.com/DangerKlippers/danger-klipper/pull/333. Primary focus was to bring the overall content format inline with other documents and make setup and configuration clear and concise. Feedback from the beta was integrated to support common issues and questions. Bed setup was moved to experimental section to help clarify that currently MPC is primary intended to be used with the extruder heater. No significant content removals IMO.
The following areas were added:
As with all documentation updates, I welcome review and feedback.
Checklist