Fix hasPreparedInternalModule is always false. (apache#11535)

KamToHung · Feb 12, 2023 · 8725323 · 8725323
1 parent 18d899b
commit 8725323
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...o-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java b/...o-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java
@@ -716,11 +716,11 @@ public void prepareInternalModule() {
                 // wait for internal module startup
                 try {
                     future.get(5, TimeUnit.SECONDS);
+                    hasPreparedInternalModule = true;
                 } catch (Exception e) {
                     logger.warn(CONFIG_FAILED_START_MODEL, "", "", "wait for internal module startup failed: " + e.getMessage(), e);
                 }
             }
-            hasPreparedInternalModule = true;
         }
     }
 
@@ -773,7 +773,7 @@ private DynamicConfiguration prepareEnvironment(ConfigCenterConfig configCenter)
                 dynamicConfiguration = getDynamicConfiguration(configCenter.toUrl());
             } catch (Exception e) {
                 if (!configCenter.isCheck()) {
-                    logger.warn(CONFIG_FAILED_INIT_CONFIG_CENTER, "", "","The configuration center failed to initialize", e);
+                    logger.warn(CONFIG_FAILED_INIT_CONFIG_CENTER, "", "", "The configuration center failed to initialize", e);
                     configCenter.setInitialized(false);
                     return null;
                 } else {