-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ktor CacheStorage
based persistent cache
#61
Conversation
Amazing, thanks a lot for the contribution! I've been planning to work on #27 for a while, you've beaten me to it 🙌. I'll review this as soon as I can. In the meantime I can publish a snapshot if you want. |
Please take your time to review it. I had to reorganize the codebase to be able to share the common code between different JVM targets and also specify Android-specific things at the same time. I'm open to any suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just have a few questions basically.
kamel-image/src/commonMain/kotlin/io/kamel/image/config/KamelConfig.kt
Outdated
Show resolved
Hide resolved
kamel-core/src/androidMain/kotlin/io/kamel/core/ApplicationContextInitializer.kt
Outdated
Show resolved
Hide resolved
Looks good thanks again! @psuzn |
This adds a persistent disk cache based on the ktor's
CacheStorage
. The underlying cache is a disk LRU is a multiplatform port of coil's DiskLruCache (which itself is a port from libcore disklrucache).HttpCache
can be configured as