-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YAML as a valid extension for the settings file #441
Add YAML as a valid extension for the settings file #441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to support this in
selene/selene/src/standard_library.rs
Line 74 in 4624569
let yaml_file = directory.join(format!("{standard_library_name}.yml")); |
Also make sure to add this to the Added
section of the CHANGELOG.
Thanks for the PR!
docs/src/roblox.md
Outdated
@@ -24,7 +24,7 @@ Roblox has provided an open source testing utility called [TestEZ](https://roblo | |||
|
|||
`std = "roblox+testez"` | |||
|
|||
But first you'll need to create a `testez.yml` file, which you can do so [with this template](https://gist.github.com/Kampfkarren/f2dddc2ebfa4e0662e44b8702e519c2d). | |||
But first you'll need to create a `testez.yml` or `testez.yaml` file, which you can do so [with this template](https://gist.github.com/Kampfkarren/f2dddc2ebfa4e0662e44b8702e519c2d). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just recommend testez.yml
for now, .yaml
being supported is something we can put in a separate documentation file, the standard library one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In commit 9bc22fb:
The change has been reverted and the roblox.md
file is now untouched.
The condition has been set for ensuring that .yaml
is also considered in standard_library.rs
file.
The Changelog has been modified.
Added CHANGELOG changes and standard_library modifications
Co-authored-by: boyned//Kampfkarren <boynedmaster@gmail.com>
Co-authored-by: boyned//Kampfkarren <boynedmaster@gmail.com>
Will test this later this week, but this looks good to me. Thanks! |
Tested and working, thanks! |
The current PR solves #408 by appending
yaml
as the list of valid extensions for thestd
configuration files.The current solution requires to be tested by the issue creator or a project maintainer.
Also, considering that this is my first contribution to the project, could you kindly set a review on my proceeding @Kampfkarren?
Thank you in advance.