Refactor: split dataSource from graphic walker #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
islxyqwe
commented
Aug 15, 2023
•
islxyqwe
commented
- Split DataSource Segment and Graphic Walker, make it possible to customize the data source.
- Split VisualConfig into VisualConfig(change will cause recalculate) and VisualLayout(won't cause recalculate)
- The change on the chart become replayable.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
islxyqwe
changed the title
islxyqwe
force-pushed
the
refactor-store
branch
from
0fefa05 to
dfdd8a3
Compare
islxyqwe
force-pushed
the
refactor-store
branch
from
dfdd8a3 to
7504df7
Compare
islxyqwe
force-pushed
the
refactor-store
branch
from
89dd2f9 to
6214b4b
Compare
islxyqwe
changed the title
CheckList
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.