Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: color legend issue with repeated view #334

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

islxyqwe
Copy link
Member

@islxyqwe islxyqwe commented Feb 28, 2024

This PR fixes the color legend issue in repeated view.
before:
image
fixed:
image

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graphic-walker ✅ Ready (Inspect) Visit Preview Feb 28, 2024 9:29am

Copy link
Contributor

Risk Level 2 - /home/runner/work/graphic-walker/graphic-walker/packages/graphic-walker/src/lib/vega.ts

The code seems to be well written and follows the SOLID principles. However, there are some areas where the readability could be improved. For instance, the function toVegaSpec is quite long and complex. It would be beneficial to add some comments to explain what each part of the function does. Also, the use of any type for spec variable is not recommended as it can lead to potential runtime errors. Try to define a more specific type if possible.


Risk Level 2 - /home/runner/work/graphic-walker/graphic-walker/packages/graphic-walker/src/vis/spec/view.ts

The code is generally well written, but there are some areas where improvements could be made. For instance, the function getSingleView is quite long and complex. Adding comments to explain what each part of the function does would improve readability. Also, the use of any type for view variable in resolveScales function is not recommended as it can lead to potential runtime errors. Try to define a more specific type if possible.


📝🔍🚧


Powered by Code Review GPT

@ObservedObserver ObservedObserver merged commit 8fd50ca into main Feb 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants