fix: add filter in data board

[islxyqwe]

Fixed the issue that when click "DataView" in a filtered chart, the data in dialog will contains data that not filtered.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
graphic-walker	✅ Ready (Inspect)	Visit Preview	Mar 1, 2024 6:01am

[github-actions]

Risk Level 2 - /home/runner/work/graphic-walker/graphic-walker/packages/graphic-walker/src/components/dataBoard.tsx

The code changes seem to be well written and follow good practices. However, there are a few points that could be improved for better readability and maintainability:

1. Use of magic strings: The code contains magic strings such as 'one of', 'expr'. It would be better to replace these magic strings with constants. This would make the code more maintainable and less error-prone.

2. Complexity of useMemo hooks: The useMemo hooks are doing a lot of work and it might be hard to understand what's going on at first glance. Consider breaking down the logic inside useMemo into smaller, well-named functions to improve readability.

3. Type assertion: There is a type assertion x.fid! in the code. It's generally better to avoid type assertions if possible, as they can potentially hide real issues. Consider adding proper checks or using optional chaining.

Example:

computedFileds.map((x) => ({
  expression: processExpression(x.expression!, allFields, config),
  key: x.fid ? x.fid : 'default',
}))

4. Encoding filter rules: The function encodeFilterRule is being used to encode filter rules. Make sure that this function handles all possible edge cases and errors to avoid potential bugs.

---

🔮💡🔍

---

Powered by Code Review GPT