feat: add hide-nav config for web use

[islxyqwe]

add a new prop: hideChartNav to hide the chart navigation.
usage:

<GraphicWalker {...props} hideChartNav />

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
graphic-walker	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 8, 2024 7:45am

[github-actions]

Risk Level 2 - /home/runner/work/graphic-walker/graphic-walker/packages/graphic-walker/src/App.tsx

The code changes seem to be mostly about UI and layout adjustments, and the addition of a utility function parseErrorMessage. There are no obvious bugs or performance issues. However, there are a few areas that could be improved for readability and maintainability:

1. Use of magic numbers: The code contains magic numbers, such as 501 in the reportError function and 60000 for computationTimeout. It would be better to replace these with named constants to improve readability and maintainability.

2. Complexity of the useEffect hooks: There are multiple useEffect hooks with complex logic inside. It would be better to extract this logic into separate functions with descriptive names.

3. Inconsistent use of optional chaining: In some places, optional chaining (?.) is used, but in others it is not. It would be better to use it consistently to avoid potential undefined errors.

Here are some example changes:

// Replace magic numbers with named constants
const DEFAULT_COMPUTATION_TIMEOUT = 60000;
const ERROR_CODE = 501;

// Extract complex logic into separate functions
const handleGeographicDataUpdate = () => {
  if (geographicData) {
    vizStore.setGeographicData(geographicData, geographicData.key);
  }
};

useEffect(handleGeographicDataUpdate, [vizStore, geographicData]);

// Use optional chaining consistently
onError?.(err);

}

---

🔮💡🔗

---

Powered by Code Review GPT