fix: repeat with null

[islxyqwe]

fix the issue that chart cannot render when repeat with null x-axis or y-axis.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
graphic-walker	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 12, 2024 11:19am

[github-actions]

Risk Level 2 - /home/runner/work/graphic-walker/graphic-walker/packages/graphic-walker/src/lib/vega.ts

The code changes are generally safe and follow good practices. However, there are a few areas that could be improved for readability and maintainability:

1. Use of any type: The spec variable is declared with any type. This could potentially lead to runtime errors. It's recommended to use a specific type or interface to provide better type safety.

const spec: any = {
  data: {
    values: dataSource,
  },
  params: [
    {
      name: 'geom',
      select: {
        type: 'point',
        fields: geomFieldIds.map(encodeFid),
      },
    },
  ],
};

2. Complex function: The toVegaSpec function is quite complex and long. It might be beneficial to break it down into smaller, more manageable functions. This would improve readability and maintainability of the code.

3. Magic numbers: The numbers 5 and 1 are used directly in the code. It's recommended to replace these magic numbers with named constants to improve readability and maintainability.

const PADDING = 5;
const MIN_REPEAT_FIELDS = 1;

4. Use of let: The let keyword is used for variables that are not reassigned. It's recommended to use const instead to ensure immutability.

const index = 0;
const result = new Array(rowRepeatFields.length * colRepeatFields.length);

---

🔍📚🔧

---

Powered by Code Review GPT