Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DON'T MERGE] feat(Form): Introduce Kaoto Form V2 #1939

Draft
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Jan 23, 2025

Context

Currently, uniforms-patternfly doesn't support anyOf nor oneOf schemas and this limits the EIPs that we could configure using the CanvasForm.

Changes

This PR builds a Form component chain to add support for anyOf & oneOf schemas so it better reflects the Caml YAML DSL schema.

Pending UI changes

Pending Catalog generator changes

fix: #1934
fix: #1913
fix: #794
fix: #1942
fix: #966
fix: #705
fix: #1972
fix: #1945
fix: #1994
fix: #1624
fix: #1628

Sorry, something went wrong.

tplevko and others added 2 commits February 14, 2025 14:59
Shivam Gupta and others added 7 commits February 17, 2025 13:46
The `onWhen` property uses the same `when` definition, but it doesn't
support steps, so it only serves the purpose of enabling an `expression`
in an `onCompletion` entity.
This iteration updates the `setValue` function to remove non-existing
properties from the target object that doesn't exist in the source object.

By updating this, both `expressionProperty` and `expressionRoot` are
treated the same, reducing the code.
At this time, we're extracting the logic from the `OneOfField` component
so we can reuse it for the `ExpressionFieldInner` component.

The reason for this is toco place the `SchemaList` component inside of
the `ArrayFieldWrapper`, so the field looks more compact.

In addition to that, the children are only rendered if they are defined
or, in case of array children, if the array has one element or more.
lordrip and others added 2 commits February 17, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment