Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamped tests #157

Merged
merged 21 commits into from
Apr 16, 2018
Merged

Revamped tests #157

merged 21 commits into from
Apr 16, 2018

Conversation

KarelCemus
Copy link
Owner

@KarelCemus KarelCemus commented Apr 13, 2018

Revamped tests fixes #108

  • reduced number of tests
  • increased their value
  • increased code coverage
  • used smaller number of unit tests with mocks instead of large number of integration test
  • fixed several minor issues identified through tests

@KarelCemus KarelCemus added this to the 2.1.0 milestone Apr 13, 2018
@KarelCemus
Copy link
Owner Author

@pcejrowski I've revamped tests to have better coverage. Basically, the tests now cover everything but the cluster. It is the only thing left. Do you have any experience setting up the cluster in Travis? If so, could you give me some help, please?

@pcejrowski
Copy link
Contributor

pcejrowski commented Apr 15, 2018

Hi @KarelCemus!
I have no former experience with that but would be happy to help. I will take care of it later the following workweek.
What am I going to do?
Replace Travis' default redis-server service with grokzen/redis-cluster

The cluster is 6 redis instances running with 3 master & 3 slaves, one slave for each master. They run on ports 7000 to 7005. It also contains 2 standalone instances that is not part of the cluster. They are running on port 7006 & 7007

So that, the standalone instances can be used for current tests and the cluster for the cluster-related features.

@KarelCemus
Copy link
Owner Author

@pcejrowski Thanks, that would be awesome if you could help. I've opened #158 for this task.

I'd be great if you could set up Travis so that we could run tests against both standalone and cluster instances. The standalone is already setup thus only the cluster is missing. If it is possible, it would be nice to integrate that grokzen/redis-cluster into Travis. It would solve all issue. I'd then implement the tests.

@KarelCemus KarelCemus merged commit 41782a4 into master Apr 16, 2018
@KarelCemus KarelCemus deleted the tests branch April 16, 2018 06:31
@KarelCemus
Copy link
Owner Author

It also contains 2 standalone instances that is not part of the cluster. They are running on port 7006 & 7007

I believe we don't need these, there is already running a standalone instance

@KarelCemus
Copy link
Owner Author

Moving this discussion into #158.

KarelCemus added a commit that referenced this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests refactoring
2 participants