Use java8 Base64 implementation for jdk10 compat #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
easel
commented
May 5, 2018
easel
commented
- Adjust tests to explicitly join base64 strings prior to comparison
|
Hi, thank you for contribution. Your PR looks good but 2 points:
|
- Adjust tests to explicitly join base64 strings prior to comparison - Add CHANGELOG.md entry
|
@KarelCemus thanks for the quick feedback. I've rebased and added a changelog entry, take a look. Cross my fingers for a green build with your tests fixes =p |
|
Great, thanks for your work |
|
Likewise, thanks for the code and the merge! |
KarelCemus
added a commit
that referenced
this pull request
Dec 2, 2020
Use java8 Base64 implementation for jdk10 compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.