Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Wait task #22

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Add a Wait task #22

merged 7 commits into from
Sep 12, 2024

Conversation

jonipol
Copy link
Contributor

@jonipol jonipol commented Sep 10, 2024

Add a "Wait" task.

Task to wait for given time or until canceled if duration <= 0.0.

Additionally refactored the system tasks a little bit to make them look nicer.

Signed-off-by: Joni Pöllänen <joni.pollanen@karelics.fi>
Signed-off-by: Joni Pöllänen <joni.pollanen@karelics.fi>
Signed-off-by: Joni Pöllänen <joni.pollanen@karelics.fi>
@Jannkar
Copy link
Collaborator

Jannkar commented Sep 10, 2024

Looking good! README should be updated with the new system task.

Signed-off-by: Joni Pöllänen <joni.pollanen@karelics.fi>
@jonipol
Copy link
Contributor Author

jonipol commented Sep 11, 2024

Updated the readme. That was something I thought of right after I left the office yesterday. 👍

Signed-off-by: Joni Pöllänen <joni.pollanen@karelics.fi>
Copy link
Member

@tanelikor tanelikor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, found a couple minor things to check / discuss. Otherwise this is good to go.

task_manager/task_manager/tasks/system_tasks.py Outdated Show resolved Hide resolved
Signed-off-by: Joni Pöllänen <joni.pollanen@karelics.fi>
… report success.

Signed-off-by: Joni Pöllänen <joni.pollanen@karelics.fi>
@jonipol jonipol merged commit 8c70a5d into main Sep 12, 2024
1 check passed
@jonipol jonipol deleted the wait-task branch September 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants