KRKPD-996: refactors interpretResponse #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klawil
reviewed
Apr 10, 2024
modules/kargoBidAdapter.js
Outdated
| height: adUnit.height, | ||
| ttl: 300, | ||
| creativeId: adUnit.creativeID, | ||
| cpm: Number(adUnit.cpm) || 0, |
There was a problem hiding this comment.
Is there a way we could track errors around these default statements? My concern is we might mask issues returning invalid bids
There was a problem hiding this comment.
It looks like we don't currently track any adapter errors, so adding this here wouldn't be useful. We should look into adding adapter error tracking and track these fallbacks as types of errors in the future
There was a problem hiding this comment.
Yea I've got a ticket for that now under the prebid maintenance epic
klawil
approved these changes
Apr 10, 2024
ssadman22
approved these changes
Apr 12, 2024
elixsantana
approved these changes
Apr 12, 2024
nickllerandi
added a commit
that referenced
this pull request
Apr 15, 2024
* refactors interpretResponse * updates comment * simpler * removes unnecessary comment * removes more unnecessary comments * revert ttl * reverts ttl test values * revert some || changes * removes comments --------- Co-authored-by: “Nick <“nick.llerandi”@kargo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
(https://github.com/prebid/Prebid.js/blob/de42f8d23da4d84c6e761aec1c2e3510e6dd3bd9/modules/rubiconBidAdapter.js#L685))