Fix possibly invalid target_temp_high in trv.py #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
target_temp_high is the cooling temperature and mapped to zigbee occupied_cooling_temperature target_temp_low is the heating temperature and mapped to zigbee occupied_heating_temperature
This was referenced Nov 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Bosch Thermostat having attributes target_temp_high and target_temp_low (and no temperature) having issues when changing the temperature locally. Changes were not communicated back properly.
Reference: #1422 (comment)
Changing target_temp_high to target_temp_low in trv.py fixed this.
On deeper investigation it seems that Zigbee occupied_heating_temperature is converted to target_temp_low.
Inspecting 1797332 reveals that in cooler.py and trv.py the temperature is set using target_temp_high. This should be correct for cooler.py, but most propably not in trv.py
Changes:
Changes target_temp_high to target_temp_low in trv.py.
Related issue (check one):
Checklist (check one):
Test-Hardware list (for code changes)
HA Version: 2024.11.0
Zigbee2MQTT Version: 1.41.0
TRV Hardware: Bosch Thermostat II