[PR] Preparing 2.0 Release #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the issue with multiprocessing is that the SC2InfoExtractorGo downloads the maps to get the localized map name into the final JSON file. Due to this there cannot be multiple processes running unless all of the required maps are download prior to executing the SC2InfoExtractorGo. This could be changed in the future if the first pass is ran with -download_maps_only
[PR] Draft of Docker Docs
This was referenced Nov 17, 2024
[PR] Bumped Dependency Versions
[PR] Default Flag Values for Golang
[PR] Ran Tests, Fixing Commands
[PR] Copying Scripts to Top in Docker Images
[PR] Added Docker Releases On main,dev Push and Release
[PR] Added Maps Needed for SC2InfoExtractorGo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title suggest, I've been using and refactoring these tools extensively. These were used to prepare the SC2EGSet. After the initial release I've been set on simplifying the process of updating the aforementioned dataset.
Right now the refactor, and the functionality of these tools are close to completion. I am conducting final checks/tests on the software.
I will be live testing most (if not all) of the changes when preparing the update of SC2EGSet.
Related Issues
Motivation and Context
As stated in the initial description.
How Has This Been Tested?
Not tested yet, but won't be merged before fully processing the new SC2EGSet update.