A few corrections to radmon scripts

Refs NOAA-EMC#1925
KateFriedman-NOAA · Nov 28, 2023 · 2da1a9d · 2da1a9d
1 parent ba6b2f9
commit 2da1a9d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/scripts/exgdas_atmos_verfrad.sh b/scripts/exgdas_atmos_verfrad.sh
@@ -97,15 +97,15 @@ if [[ -s ${radstat} && -s ${biascr} ]]; then
       fi
 
       if [[ $(find . -maxdepth 1 -type f -name "diag_${type}_ges.${PDY}${cyc}*.${Z}" | wc -l) -gt 0 ]]; then
-        mv "diag_${type}_ges.${PDY}${cyc}*.${Z}" "${type}.${Z}"
+        mv diag_${type}_ges.${PDY}${cyc}*.${Z} "${type}.${Z}"
         ${UNCOMPRESS} "./${type}.${Z}"
       else
         echo "WARNING: diag_${type}_ges.${PDY}${cyc}*.${Z} not available, skipping"
       fi
 
       if [[ $USE_ANL -eq 1 ]]; then
         if [[ $(find . -maxdepth 1 -type f -name "diag_${type}_anl.${PDY}${cyc}*.${Z}" | wc -l) -gt 0 ]]; then
-          mv "diag_${type}_anl.${PDY}${cyc}*.${Z}" "${type}_anl.${Z}"
+          mv diag_${type}_anl.${PDY}${cyc}*.${Z} "${type}_anl.${Z}"
           ${UNCOMPRESS} "./${type}_anl.${Z}"
         else
           echo "WARNING: diag_${type}_anl.${PDY}${cyc}*.${Z} not available, skipping"

diff --git a/ush/radmon_verf_angle.sh b/ush/radmon_verf_angle.sh
@@ -200,7 +200,7 @@ EOF
    done    # for type in ${SATYPE} loop
 
 
-   "${USHgfs}"/rstprod.sh
+   "${USHgfs}/rstprod.sh"
 
    tar_file=radmon_angle.tar
    if compgen -G "angle*.ieee_d*" > /dev/null || compgen -G "angle*.ctl*" > /dev/null; then

diff --git a/ush/radmon_verf_time.sh b/ush/radmon_verf_time.sh
@@ -131,11 +131,10 @@ if [[ ! -s ./${time_exec} ]]; then
    err=8
 fi
 
-iyy=$(echo "${PDY}" | cut -c1-4)
-imm=$(echo "${PDY}" | cut -c5-6)
-idd=$(echo "${PDY}" | cut -c7-8)
+iyy="${PDY:0:4}"
+imm="${PDY:4:2}"
+idd="${PDY:6:2}"
 ihh=${cyc}
-CYCLE=${cyc}
 
 local_base="local_base"
 if [[ ${DO_DATA_RPT} -eq 1 ]]; then