Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing character and people fields #393

Merged
merged 6 commits into from
May 31, 2023
Merged

Add missing character and people fields #393

merged 6 commits into from
May 31, 2023

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented May 30, 2023

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

Code Generators

The use of GitHub Copilot or ChatGPT is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot or ChatGPT.

Changes Made

List any changes made and/or other relevant issues.

https://github.com/KatsuteDev/Mal4J/actions/runs/5135268260

Release Notes

These are from undocumented features, you must use MyAnimeList.enableExperimentalFeature(ExperimentalFeature.CHARACTERS) and MyAnimeList.enableExperimentalFeature(ExperimentalFeature.PEOPLE) to enable them.

  • Add favorites count to character and people
  • Add alternative names and 'more' field to people
  • Add method to retrieve character biography details as a map

@Katsute Katsute self-assigned this May 30, 2023
@Katsute Katsute linked an issue May 30, 2023 that may be closed by this pull request
@Katsute
Copy link
Member Author

Katsute commented May 30, 2023

todo:

  • split map pairs on \r\n, remove <br />

  • split kv on :

  • add non kv to __ or * key

    append if already set

@Katsute Katsute marked this pull request as ready for review May 31, 2023 02:20
@Katsute

This comment has been minimized.

@ghost

This comment has been minimized.

@Katsute

This comment has been minimized.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @Katsute

@Katsute Katsute merged commit f339fbf into main May 31, 2023
@Katsute Katsute deleted the missing@0426283 branch May 31, 2023 16:53
@ghost ghost locked and limited conversation to collaborators May 31, 2023
@Katsute Katsute added this to the 3.4.0 milestone May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing fields
1 participant