Allow proxy service work without metrics DB to allow db drop #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boodyvo
force-pushed
the
refactor-metric-db
branch
from
79ab2e7 to
1bc873c
Compare
boodyvo
commented
Sep 16, 2024
| "time" | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
Migrated partition part of the code into database, as it is based on the implementation details of the db itself
boodyvo
commented
Sep 16, 2024
clients/database/empty/database.go
Outdated
| @@ -0,0 +1,41 @@ | |||
| package empty | |||
There was a problem hiding this comment.
Empty implementation, that will be used in case of metric database disabled
boodyvo
requested review from
evgeniy-scherbina,
pirtleshell,
DracoLi,
nddeluca and
drklee3
drklee3
reviewed
Sep 16, 2024
drklee3
approved these changes
Sep 16, 2024
boodyvo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
METRIC_DATABASE_ENABLED=falsewe can run proxy without database dependency.noop(to use when metrics is disabled) andpostgres(current implementation of db)