-
Notifications
You must be signed in to change notification settings - Fork 370
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(x/precisebank): Return full balances in GetBalance(), add Spenda…
…bleCoin method (#1957) Change GetBalance() to return full balances instead of spendable to align behavior with x/bank. Add SpendableCoin() method with support of akava for use in x/evm.
- Loading branch information
Showing
5 changed files
with
293 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| package keeper_test | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| sdkmath "cosmossdk.io/math" | ||
| sdk "github.com/cosmos/cosmos-sdk/types" | ||
| authtypes "github.com/cosmos/cosmos-sdk/x/auth/types" | ||
| vestingtypes "github.com/cosmos/cosmos-sdk/x/auth/vesting/types" | ||
|
|
||
| "github.com/kava-labs/kava/x/precisebank/testutil" | ||
| "github.com/kava-labs/kava/x/precisebank/types" | ||
| "github.com/stretchr/testify/suite" | ||
| ) | ||
|
|
||
| type viewIntegrationTestSuite struct { | ||
| testutil.Suite | ||
| } | ||
|
|
||
| func (suite *viewIntegrationTestSuite) SetupTest() { | ||
| suite.Suite.SetupTest() | ||
| } | ||
|
|
||
| func TestViewIntegrationTestSuite(t *testing.T) { | ||
| suite.Run(t, new(viewIntegrationTestSuite)) | ||
| } | ||
|
|
||
| func (suite *viewIntegrationTestSuite) TestKeeper_SpendableCoin() { | ||
| tests := []struct { | ||
| name string | ||
| giveDenom string // queried denom for balance | ||
|
|
||
| giveBankBal sdk.Coins // full balance | ||
| giveFractionalBal sdkmath.Int // stored fractional balance for giveAddr | ||
| giveLockedCoins sdk.Coins // locked coins | ||
|
|
||
| wantSpendableBal sdk.Coin | ||
| }{ | ||
| { | ||
| "extended denom, no fractional - locked coins", | ||
| types.ExtendedCoinDenom, | ||
| // queried bank balance in ukava when querying for akava | ||
| sdk.NewCoins(sdk.NewCoin(types.IntegerCoinDenom, sdk.NewInt(1000))), | ||
| sdkmath.ZeroInt(), | ||
| sdk.NewCoins(sdk.NewCoin(types.IntegerCoinDenom, sdk.NewInt(10))), | ||
| // (integer + fractional) - locked | ||
| sdk.NewCoin( | ||
| types.ExtendedCoinDenom, | ||
| types.ConversionFactor().MulRaw(1000-10), | ||
| ), | ||
| }, | ||
| { | ||
| "extended denom, with fractional - locked coins", | ||
| types.ExtendedCoinDenom, | ||
| // queried bank balance in ukava when querying for akava | ||
| sdk.NewCoins(sdk.NewCoin(types.IntegerCoinDenom, sdk.NewInt(1000))), | ||
| sdkmath.NewInt(5000), | ||
| sdk.NewCoins(sdk.NewCoin(types.IntegerCoinDenom, sdk.NewInt(10))), | ||
| sdk.NewCoin( | ||
| types.ExtendedCoinDenom, | ||
| // (integer - locked) + fractional | ||
| types.ConversionFactor().MulRaw(1000-10).AddRaw(5000), | ||
| ), | ||
| }, | ||
| { | ||
| "non-extended denom - ukava returns ukava", | ||
| types.IntegerCoinDenom, | ||
| sdk.NewCoins(sdk.NewCoin(types.IntegerCoinDenom, sdk.NewInt(1000))), | ||
| sdkmath.ZeroInt(), | ||
| sdk.NewCoins(sdk.NewCoin(types.IntegerCoinDenom, sdk.NewInt(10))), | ||
| sdk.NewCoin(types.IntegerCoinDenom, sdk.NewInt(990)), | ||
| }, | ||
| { | ||
| "non-extended denom, with fractional - ukava returns ukava", | ||
| types.IntegerCoinDenom, | ||
| sdk.NewCoins(sdk.NewCoin(types.IntegerCoinDenom, sdk.NewInt(1000))), | ||
| // does not affect balance | ||
| sdkmath.NewInt(100), | ||
| sdk.NewCoins(sdk.NewCoin(types.IntegerCoinDenom, sdk.NewInt(10))), | ||
| sdk.NewCoin(types.IntegerCoinDenom, sdk.NewInt(990)), | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| suite.Run(tt.name, func() { | ||
| suite.SetupTest() | ||
|
|
||
| addr := sdk.AccAddress([]byte("test-address")) | ||
|
|
||
| suite.MintToAccount(addr, tt.giveBankBal) | ||
|
|
||
| // Set fractional balance in store before query | ||
| suite.Keeper.SetFractionalBalance(suite.Ctx, addr, tt.giveFractionalBal) | ||
|
|
||
| // Add some locked coins | ||
| acc := suite.AccountKeeper.GetAccount(suite.Ctx, addr) | ||
| if acc == nil { | ||
| acc = authtypes.NewBaseAccount(addr, nil, 0, 0) | ||
| } | ||
|
|
||
| vestingAcc := vestingtypes.NewPeriodicVestingAccount( | ||
| acc.(*authtypes.BaseAccount), | ||
| tt.giveLockedCoins, | ||
| suite.Ctx.BlockTime().Unix(), | ||
| vestingtypes.Periods{ | ||
| vestingtypes.Period{ | ||
| Length: 100, | ||
| Amount: tt.giveLockedCoins, | ||
| }, | ||
| }, | ||
| ) | ||
| suite.AccountKeeper.SetAccount(suite.Ctx, vestingAcc) | ||
|
|
||
| fetchedLockedCoins := vestingAcc.LockedCoins(suite.Ctx.BlockTime()) | ||
| suite.Require().Equal( | ||
| tt.giveLockedCoins, | ||
| fetchedLockedCoins, | ||
| "locked coins should be matching at current block time", | ||
| ) | ||
|
|
||
| spendableCoinsWithLocked := suite.Keeper.SpendableCoin(suite.Ctx, addr, tt.giveDenom) | ||
|
|
||
| suite.Require().Equalf( | ||
| tt.wantSpendableBal, | ||
| spendableCoinsWithLocked, | ||
| "expected spendable coins of denom %s", | ||
| tt.giveDenom, | ||
| ) | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.