Remove expired vesting periods from accounts in migrations #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spendable balance, and other vesting specific functions
nddeluca
reviewed
Jan 6, 2022
| @@ -13,8 +13,8 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| GenesisTime = time.Date(2021, 11, 30, 15, 0, 0, 0, time.UTC) | |||
| ChainID = "kava-8" | |||
| GenesisTime = time.Date(2022, 1, 19, 16, 0, 0, 0, time.UTC) | |||
There was a problem hiding this comment.
Genesis time is updated to launch date
nddeluca
reviewed
Jan 6, 2022
| GenesisTime = time.Date(2021, 11, 30, 15, 0, 0, 0, time.UTC) | ||
| ChainID = "kava-8" | ||
| GenesisTime = time.Date(2022, 1, 19, 16, 0, 0, 0, time.UTC) | ||
| ChainID = "kava-9" |
nddeluca
reviewed
Jan 6, 2022
| @@ -43,3 +56,115 @@ func TestMigrateFull(t *testing.T) { | |||
| tApp.InitializeFromGenesisStatesWithTimeAndChainID(newGenDoc.GenesisTime, newGenDoc.ChainID, app.GenesisState(appMap)) | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccountBalances(t *testing.T) { | |||
| t.Skip() // avoid committing test data | |||
There was a problem hiding this comment.
Skipped in integration, passing locally against exported state of block 1627000
nddeluca
reviewed
Jan 6, 2022
| @@ -0,0 +1,485 @@ | |||
| package legacyaccounts | |||
There was a problem hiding this comment.
This is used in the migrate test instead of the legacy types from the cosmos-sdk. The cosmos-sdk types do not implement Spendable, etc methods.
|
Added an e2e test and account migration looks good |
nddeluca
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResetPeriodicVestingAccountfunction copied from v15 migration.Testing
Updates the tests to use a fixed test genesis time to allow for the actual migration genesis time to be changed without breaking tests.
Test data json file changes: