Make QueryAuctionsResponse auctions field plural
#1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is somewhat misleading
nddeluca
reviewed
Dec 31, 2021
| @@ -13,7 +13,6 @@ require ( | |||
| github.com/grpc-ecosystem/grpc-gateway v1.16.0 | |||
| github.com/spf13/cast v1.3.1 | |||
| github.com/spf13/cobra v1.2.1 | |||
| github.com/spf13/viper v1.8.1 | |||
There was a problem hiding this comment.
This is from me removing the kvcli, kvd directories and not cleaning of up mods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it consistent with other requests that respond with multiple values.
This is a breaking change, but as far as I know only auction bot currently requires and uses this query response.