Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use string over bytes and keep hex encoding in messages #1122

Merged
merged 1 commit into from
Jan 7, 2022
Merged

use string over bytes and keep hex encoding in messages #1122

merged 1 commit into from
Jan 7, 2022

Conversation

nddeluca
Copy link
Member

@nddeluca nddeluca commented Jan 6, 2022

No description provided.

rhuairahrighairidh
rhuairahrighairidh approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@rhuairahrighairidh rhuairahrighairidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nddeluca nddeluca marked this pull request as ready for review January 6, 2022 19:58
denalimarsh
denalimarsh approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@denalimarsh denalimarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that this fixes the type issues.

@denalimarsh denalimarsh mentioned this pull request Jan 7, 2022
Merged
@nddeluca nddeluca merged commit e64e7f7 into upgrade-v44 Jan 7, 2022
@nddeluca nddeluca deleted the nd-bep3-use-strings-with-hex branch January 7, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuairahrighairidh rhuairahrighairidh rhuairahrighairidh approved these changes

@denalimarsh denalimarsh denalimarsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nddeluca @rhuairahrighairidh @denalimarsh