feat: re-add validator-vesting legacy rest endpoints #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galxy25
reviewed
Apr 6, 2023
|
|
||
| // ReadRESTReq reads and unmarshals a Request's body to the the BaseReq struct. | ||
| // Writes an error response to ResponseWriter and returns false if errors occurred. | ||
| func ReadRESTReq(w http.ResponseWriter, r *http.Request, cdc *codec.LegacyAmino, req interface{}) bool { |
There was a problem hiding this comment.
to the BaseReq struct
Idiomatic go is to return error vs bool to signal error and have callers check if nil -> https://go.dev/doc/effective_go#multiple-returns
There was a problem hiding this comment.
The rest files are just the removed files from cosmos temporarily copied while we support the endpoints, I'll just leave it as is for now since we may be removing it later again 😅
galxy25
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the legacy
/vesting/*rest endpoints back, along with the required cosmos methods.Checklist