Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.mod replace directives #1544

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Update go.mod replace directives #1544

merged 3 commits into from
Apr 11, 2023

Conversation

drklee3
Copy link
Member

@drklee3 drklee3 commented Apr 8, 2023

Description

These updates follow the Cosmos SDK replacements.

  • Remove replace for github.com/confio/ics23/go, v0.9.0 includes dragonberry security patch
  • Update github.com/cosmos/keyring to v1.2.0.
  • Add github.com/dgrijalva/jwt-go replacement for security issue.

There is one replacement in Cosmos SDK that is not included, unclear the reasoning why this was added:

  • github.com/jhump/protoreflect => github.com/jhump/protoreflect v1.9.0

Additional version change to address minor security alert

Checklist

  • Changelog has been updated as necessary.

@drklee3 drklee3 marked this pull request as ready for review April 8, 2023 00:21
Copy link
Member

@rhuairahrighairidh rhuairahrighairidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch with the go-getter upgrade.
I had a look were the jhump/protoreflect replace came from. It was pretty unclear why it was added. But it's only used in a cosmos-sdk test so seems fine to ignore.

@drklee3 drklee3 merged commit c12ad1d into master Apr 11, 2023
@drklee3 drklee3 deleted the dl-go.mod branch April 11, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants