feat: add community cdp repay debt proposal #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the proposal does not interact with the vanilla community pool
pirtleshell
changed the title
pirtleshell
requested review from
nddeluca,
rhuairahrighairidh,
karzak and
drklee3
1 task
pirtleshell
force-pushed
the
rp-community-cdp-repay-debt-proposal
branch
from
30cd64a
to
afc38bb
Compare
drklee3
reviewed
Apr 19, 2023
pirtleshell
commented
Apr 20, 2023
| app.distrKeeper, | ||
| hardKeeper, | ||
| &hardKeeper, |
There was a problem hiding this comment.
creating a public record of the fact that because this was originally passed as a copy, any positions it created never had claims instantiated (because the hooks do not get registered to the copy).
this may have consequences for the open lend position held by the community module.
There was a problem hiding this comment.
confirmed with @rhuairahrighairidh any fixes needed for this would be in a follow up pr. commencing merge!
DracoLi
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
x/communityproposalCommunityCDPRepayDebtProposalwhich repays debts owned by the community module with community module fundsFollow up PR (#1566) adds corresponding committee permission for submission via committee.
Note: Does not include custom CLI command.
Checklist