feat(evmutil): implement MsgConvertCosmosCoinFromERC20 #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirtleshell
requested review from
DracoLi,
nddeluca,
rhuairahrighairidh,
galxy25 and
drklee3
galxy25
approved these changes
Jun 1, 2023
DracoLi
reviewed
Jun 2, 2023
| @@ -54,6 +54,8 @@ Only Cosmos co-chain denominations that are in the `AllowedCosmosDenoms` param ( | |||
|
|
|||
| The ERC20 contracts are deployed and managed by x/evmutil. The contract is deployed on first convert of the coin. Once deployed, the addresses of the contracts can be queried via the `DeployedCosmosCoinContracts` query (`deployed_cosmos_coin_contracts` endpoint). | |||
|
|
|||
| If a denom is removed from the `AllowedCosmosDenoms` param, existing ERC20 tokens can be converted back to the underlying sdk.Coin via `MsgConvertCosmosCoinFromERC20`, but no conversions from sdk.Coin -> ERC via `MsgConvertCosmosCoinToERC20` are allowed. | |||
There was a problem hiding this comment.
do we have a test for this expected behaviour? Might be good to include if not.
There was a problem hiding this comment.
good idea, i've added a test of the full flow, including re-enabling the coin using the original contract address:
https://github.com/Kava-Labs/kava/pull/1609/files#diff-b41fd85eddf7b0e552e3551ed6991584ba52d5d9e7605f76facbb676139dadf1R654-R659
pirtleshell
force-pushed
the
rp-convert-evm-to-sdk
branch
from
80ab4d9
to
ec47241
Compare
pirtleshell
force-pushed
the
rp-convert-evm-to-sdk-msg
branch
from
02beec0
to
7ec2266
Compare
DracoLi
approved these changes
Jun 2, 2023
pirtleshell
force-pushed
the
rp-convert-evm-to-sdk-msg
branch
from
111a84a
to
7b06210
Compare
nddeluca
reviewed
Jun 2, 2023
Comment on lines
+654
to
+659
| // the test verifies the behavior for when a denom is removed from the params list | ||
| // after conversions have been made: | ||
| // - it should prevent more conversions from sdk -> evm for that denom | ||
| // - existing erc20s should be allowed to get converted back to a sdk.Coins | ||
| // - allowing the denom again should use existing contract | ||
| func (suite *MsgServerSuite) TestConvertCosmosCoinForRemovedDenom() { |
There was a problem hiding this comment.
I missed that last case of re-enabled when reviewing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds message server implementation for MsgConvertCosmosCoinToERC20, with tests & spec updates.
Checklist