feat(evmutil): add CosmosCoinsFullyBackedInvariant #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirtleshell
requested review from
DracoLi,
nddeluca,
rhuairahrighairidh,
galxy25 and
drklee3
galxy25
approved these changes
Jun 1, 2023
pirtleshell
force-pushed
the
rp-convert-evm-to-sdk-msg
branch
from
02beec0
to
7ec2266
Compare
pirtleshell
force-pushed
the
rp-cosmos-coin-conversion-invariant
branch
from
5221e5b
to
a340b82
Compare
pirtleshell
force-pushed
the
rp-convert-evm-to-sdk-msg
branch
from
111a84a
to
7b06210
Compare
pirtleshell
force-pushed
the
rp-cosmos-coin-conversion-invariant
branch
from
a340b82
to
0032f52
Compare
rhuairahrighairidh
approved these changes
Jun 3, 2023
| @@ -1138,6 +1138,7 @@ func (app *App) loadBlockedMaccAddrs() map[string]bool { | |||
| app.accountKeeper.GetModuleAddress(kavadisttypes.FundModuleAccount).String(): true, | |||
| // community | |||
| app.accountKeeper.GetModuleAddress(communitytypes.ModuleAccountName).String(): true, | |||
| // NOTE: if adding evmutil, adjust the cosmos-coins-fully-backed-invariant accordingly. | |||
There was a problem hiding this comment.
good note, this was an issue a while ago with the distribution mod account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an invariant that ensures ERC20 total supply == module balance for sdk.Coins that can be converted to ERC20 tokens.
Checklist