Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump tm-db fork to v0.6.7-kava.3 #1622

Merged
merged 4 commits into from
Jun 9, 2023
Merged

chore: bump tm-db fork to v0.6.7-kava.3 #1622

merged 4 commits into from
Jun 9, 2023

Conversation

drklee3
Copy link
Member

@drklee3 drklee3 commented Jun 9, 2023 •
edited
Loading

Description

  • Return error when running kava with a busy rocksdb database, or any other rocksdb error when trying to open it. This now returns a relevant error instead of panicking:
# When there is already another export running
$ kava --trace --home /home/kvd-user/.kava export --for-zero-height --height 5144647
Error: failed to initialize database: IO error: While lock file: /home/kvd-user/.kava/data/application.db/LOCK: Resource temporarily unavailable

Checklist

  • Changelog has been updated as necessary.

@drklee3 drklee3 marked this pull request as ready for review June 9, 2023 18:41
@drklee3 drklee3 merged commit 0ad0d6a into release/v0.23.x Jun 9, 2023
@drklee3 drklee3 deleted the dl-rocksdb-fix-silent-err branch June 9, 2023 19:40
drklee3 added a commit that referenced this pull request Jun 9, 2023
@drklee3
chore: bump tm-db fork to v0.6.7-kava.3 (#1622)
f1154da 
* Use updated tm-db branch

* chore: bump tm-db fork to v0.6.7-kava.3

* Update changlog

* Update changlog pr number
@drklee3 drklee3 mentioned this pull request Jun 9, 2023
Merged
1 task
drklee3 added a commit that referenced this pull request Jun 9, 2023
@drklee3
chore: bump tm-db fork to v0.6.7-kava.3 (#1622) (#1623)
230ad73 
* Use updated tm-db branch

* chore: bump tm-db fork to v0.6.7-kava.3

* Update changlog

* Update changlog pr number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galxy25 galxy25 galxy25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drklee3 @galxy25