Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Resolve problem with assert-invariants cmd #1624

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

pirtleshell
Copy link
Member

Description

The assert-invariants command works by initializing a TestApp with the genesis file state, which runs the invariant checks and InitGenesis. When we added a validator to all TestApp instances in #1477, we began modifying state of the genesis being checked in assert-invariants.

This PR makes adding the validator optional so that assert-invariants checks only state in the actual genesis file.

Additionally, removes unused no-op migrate command and moves the assert-invariants command into the cmd directory.

Checklist

  • Changelog has been updated as necessary.

Copy link
Member

@nddeluca nddeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ty for the fix

@pirtleshell pirtleshell merged commit 49812b6 into master Jun 9, 2023
@pirtleshell pirtleshell deleted the rp-fix-assert-invariants branch June 9, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants