unregister x/metrics & call BeginBlocker directly #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
registering x/metrics to the module breaks the AppHash because its consensus version is added to the ModuleVersionMap which affects the AppHash. this commit unregisters the module so it is not consensus breaking. instead, it directly calls the BeginBlock before running the module manager's.
pirtleshell
requested review from
DracoLi,
nddeluca,
rhuairahrighairidh,
galxy25,
drklee3 and
evgeniy-scherbina
galxy25
approved these changes
Aug 28, 2023
nddeluca
approved these changes
Aug 28, 2023
This was referenced Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
registering x/metrics to the module manager breaks the AppHash because its consensus version is added to the ModuleVersionMap which affects the AppHash.
this commit unregisters the module so it is not consensus breaking. instead, it directly calls the BeginBlock before running the module manager's.
Checklist
Changelog has been updated as necessary.