Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unregister x/metrics & call BeginBlocker directly #1690

Merged
merged 1 commit into from
Aug 28, 2023
Merged

unregister x/metrics & call BeginBlocker directly #1690

merged 1 commit into from
Aug 28, 2023

Commits on Aug 28, 2023

  1. unregister x/metrics & call BeginBlocker directly 

    registering x/metrics to the module manager breaks the AppHash because
its consensus version is added to the ModuleVersionMap which affects the
AppHash.

this commit unregisters the module so it is not consensus breaking.
instead, it directly calls the BeginBlock before running the module
manager's.
    @pirtleshell
    pirtleshell committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    2151242 View commit details
    Browse the repository at this point in the history