Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RewardsPerSecond param to x/community module #1707

Conversation

drklee3
Copy link
Member

@drklee3 drklee3 commented Sep 13, 2023

Description

  • Add param to x/community for payout amount per second.
  • Add 744191 per second reward to protonet genesis (~4.6 KAVA per block, using 23,471,808 KAVA per year)
  • Add migration to set parameters in state

Checklist

  • Changelog has been updated as necessary.

@drklee3 drklee3 marked this pull request as ready for review September 13, 2023 22:35
proto/kava/community/v1beta1/params.proto Outdated Show resolved Hide resolved
x/community/types/params.go Outdated Show resolved Hide resolved
Copy link
Contributor

@DracoLi DracoLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe we should also update protonet and internal testnet genesis

Copy link
Member

@karzak karzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a migration?

@drklee3
Copy link
Member Author

drklee3 commented Sep 14, 2023

Does this need a migration?

Yup, will check if @rhuairahrighairidh will be adding migrations for the existing params in the target branch that I can add to or if they'll be done in a separate PR

@drklee3 drklee3 merged commit 7a8b10f into ro-incentive-restructuring-add-switchover-param Sep 18, 2023
3 checks passed
@drklee3 drklee3 deleted the dl-incentive-payout-rate-param branch September 18, 2023 16:49
rhuairahrighairidh added a commit that referenced this pull request Sep 22, 2023
* add community params type

* add get/set params methods

* add community genesis state type

* add community init/export genesis

* add querier methods for params

* add query cli cmd

* update changelog

* update protonet genesis

* Add `RewardsPerSecond` param to `x/community` module (#1707)

* Add RewardsPerSecond param to community

* Update rewards per second param to int

* Add rewards_per_second to protonet genesis

* Use default rewards per second of 744191

* Include value if negative in Validate error

* Rename RewardsPerSecond param to StakingRewardsPerSecond

* Add changelog entry

* Add param migration, update consensus version to 2

* Update proto docs

* Update staking_rewards_per_second param name in protonet genesis (#1730)

* Update godoc

Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>

* add genesis state tests

* document what 0 upgrade time means

* update kvtool to include new params

---------

Co-authored-by: drklee3 <derrick@dlee.dev>
Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants